Skip to content

fix(rh-basic): remove stale Red Hat Lightspeed MCP references#98

Merged
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
thoraxe:fix/rh-basic-remove-lightspeed-refs
May 10, 2026
Merged

fix(rh-basic): remove stale Red Hat Lightspeed MCP references#98
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
thoraxe:fix/rh-basic-remove-lightspeed-refs

Conversation

@thoraxe

@thoraxe thoraxe commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes all references to Red Hat Lightspeed MCP from rh-basic content (CLAUDE.md, README.md, collection.yaml, collection.json) — the pack uses the red-hat-security MCP server, not Lightspeed
  • Replaces "Lightspeed MCP" with "Red Hat Security MCP" in skill summary descriptions for red-hat-cve-explainer and red-hat-product-lifecycle
  • Removes the stale "Red Hat Lightspeed" entry from the resources/references sections
  • Adds the missing red-hat-security-mcp-setup skill to the README skills list, decision guide, and architecture tree, and corrects the skill count from 5 to 6

Test plan

  • Confirm no lightspeed or LIGHTSPEED references remain in rh-basic/
  • Verify red-hat-security-mcp-setup appears correctly in README skills section and decision guide
  • Confirm collection.yaml and collection.json are consistent

🤖 Generated with Claude Code

thoraxe and others added 2 commits May 8, 2026 15:26
Replace all mentions of Lightspeed MCP with the correct red-hat-security
MCP server across CLAUDE.md, README.md, collection.yaml, and collection.json.
Also adds the missing red-hat-security-mcp-setup skill to the README skills
list, decision guide, and architecture tree, and corrects the skill count
from 5 to 6.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Run catalog_yaml_to_json.py to bring collection.json back in sync after
manual edits to collection.yaml.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dmartinol

Copy link
Copy Markdown
Collaborator

/skill-code-review

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

🔄 Run #1 — 2026-05-08 20:35 UTC

Gemini Code Review

📝 Review details

1. Summary

This PR updates the rh-basic pack to replace references to the "Red Hat Lightspeed MCP" with the new "Red Hat Security MCP". It updates the catalog files, CLAUDE.md, and README.md to reflect the new server name, URL, and capabilities. It also documents the addition of a new skill: red-hat-security-mcp-setup.

2. Project Rules Compliance

I have reviewed the diff against the project rules and found the following violations:

  • Deprecated MCP Configuration Filename: In rh-basic/README.md (lines 103 and 109), the documentation states the new skill will modify .mcp.json.
    • Rule Violation: The project rules explicitly state: "Use <pack>/mcps.json for MCP server definitions... The deprecated filename .mcp.json is not used in this repository." Please update the documentation (and the underlying skill implementation) to target mcps.json.
  • ⚠️ Build Reminder: Since you are modifying catalog files (collection.json, collection.yaml) and adding a new skill, please remember to run make validate locally to ensure collection compliance and schema validation pass before merging.

3. Code Quality Issues

  • Missing File: The README.md and CLAUDE.md files document a new skill (red-hat-security-mcp-setup), and it is added to the file tree in the README. However, the actual SKILL.md file is missing from this PR diff. It looks like you forgot to git add the new skill directory before committing.
  • Skill Directory Structure: The file tree in README.md shows skills located at rh-basic/<skill-name>/SKILL.md. According to the repository structure rules, skills must be placed inside a skills/ subdirectory: rh-basic/skills/<skill-name>/SKILL.md. If the existing skills are currently at the root, they should ideally be migrated, but at a minimum, please ensure the new skill is placed in the correct skills/ directory.

4. Suggestions

  • CLAUDE.md Persona Description: In rh-basic/CLAUDE.md (line 3), you removed the phrase ", and configure the Red Hat Lightspeed MCP server." from the persona description. Since you are adding a new skill specifically to configure the new MCP server, you should update this phrase rather than deleting it entirely.
    • Suggestion: ...check product lifecycle status, determine support ticket severity, and configure the Red Hat Security MCP server.

5. Verdict

REQUEST_CHANGES

Please commit the missing SKILL.md file, update the references from .mcp.json to mcps.json to comply with repository standards, and run make validate.

Workflow run

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! /lgtm

@dmartinol dmartinol merged commit 309a560 into RHEcosystemAppEng:main May 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants