Rh virt security review

.claude/skills/skill-linter/scripts/validate-skill.sh

@@ -158,9 +158,17 @@ if [ -n "$COMPAT" ]; then
   pass "Compatibility valid ($COMPAT_LEN chars)"
 fi
 
-# Check allowed-tools (if present)
+# Check allowed-tools (optional)
 TOOLS=$(echo "$FRONTMATTER" | grep '^allowed-tools:' | sed 's/^allowed-tools:[[:space:]]*//' || true)
-if [ -n "$TOOLS" ]; then
+if [ -z "$TOOLS" ]; then
+  # Check for YAML multi-line array (allowed-tools:\n  - item)
+  if echo "$FRONTMATTER" | grep -q '^allowed-tools:$'; then
+    NEXT_LINE=$(echo "$FRONTMATTER" | grep -A1 '^allowed-tools:$' | sed -n '2p')
+    if echo "$NEXT_LINE" | grep -qE '^[[:space:]]*-[[:space:]]'; then
+      fail "allowed-tools must be space-delimited, not YAML array"
+    fi
+  fi
+else
   # FAIL if commas found (must be space-delimited)
   if echo "$TOOLS" | grep -qE ','; then
     fail "allowed-tools must be space-delimited, not comma-separated: $TOOLS"
@@ -171,13 +179,6 @@ if [ -n "$TOOLS" ]; then
     pass "Allowed-tools field valid"
   fi
 fi
-# FAIL if YAML multi-line array detected (allowed-tools:\n  - item)
-if echo "$FRONTMATTER" | grep -q '^allowed-tools:$'; then
-  NEXT_LINE=$(echo "$FRONTMATTER" | grep -A1 '^allowed-tools:$' | sed -n '2p')
-  if echo "$NEXT_LINE" | grep -qE '^[[:space:]]*-[[:space:]]'; then
-    fail "allowed-tools must be space-delimited, not YAML array"
-  fi
-fi
 
 # 8. Check line count (max 500)
 LINE_COUNT=$(wc -l < "$SKILL_FILE" | tr -d ' ')

.github/workflows/skill-code-review.yml

@@ -297,9 +297,28 @@ jobs:
           set -euo pipefail
           MARKER="<!-- gemini-code-review -->"
           WORKFLOW_URL="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+          TIMESTAMP=$(date -u '+%Y-%m-%d %H:%M UTC')
+
+          EXISTING_COMMENT_ID=$(gh api --paginate \
+            "/repos/${{ github.repository }}/issues/${PR_NUMBER}/comments" \
+            --jq ".[] | select(.body | startswith(\"$MARKER\")) | .id" \
+            | head -1)
+
+          EXISTING_BODY=""
+          RUN_NUMBER=1
+          if [ -n "$EXISTING_COMMENT_ID" ]; then
+            EXISTING_BODY=$(gh api \
+              "/repos/${{ github.repository }}/issues/comments/$EXISTING_COMMENT_ID" \
+              --jq '.body')
+            RUN_NUMBER=$(( $(echo "$EXISTING_BODY" | grep -c '### 🔄 Run #' || true) + 1 ))
+          fi
 
           {
-            echo "$MARKER"
+            if [ "$RUN_NUMBER" -eq 1 ]; then
+              echo "$MARKER"
+            fi
+            echo "### 🔄 Run #${RUN_NUMBER} — ${TIMESTAMP}"
+            echo ""
             echo "## Gemini Code Review"
             echo ""
 
@@ -317,21 +336,38 @@ jobs:
             fi
 
             echo ""
-            echo "---"
             echo "> [Workflow run]($WORKFLOW_URL)"
-          } > /tmp/comment.md
-
-          EXISTING_COMMENT_ID=$(gh api --paginate \
-            "/repos/${{ github.repository }}/issues/${PR_NUMBER}/comments" \
-            --jq ".[] | select(.body | startswith(\"$MARKER\")) | .id" \
-            | head -1)
+          } > /tmp/new_report.md
 
           if [ -n "$EXISTING_COMMENT_ID" ]; then
-            gh api --method PATCH \
+            {
+              echo "$EXISTING_BODY"
+              echo ""
+              echo "---"
+              echo ""
+              cat /tmp/new_report.md
+            } > /tmp/comment.md
+            gh api \
+              --method PATCH \
               "/repos/${{ github.repository }}/issues/comments/$EXISTING_COMMENT_ID" \
               -f body="$(cat /tmp/comment.md)"
           else
             gh pr comment "$PR_NUMBER" \
               --repo "${{ github.repository }}" \
-              --body-file /tmp/comment.md
+              --body-file /tmp/new_report.md
           fi
+
+      - name: React to PR
+        if: always()
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const result = '${{ job.status }}';
+            const prNumber = Number('${{ steps.inputs.outputs.pr_number }}');
+            await github.rest.reactions.createForIssue({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: prNumber,
+              content: result === 'success' ? '+1' : '-1'
+            });
+

.github/workflows/skill-security-scan.yml

@@ -220,6 +220,7 @@ jobs:
               --recursive \
               --use-behavioral \
               --use-llm \
+              --llm-consensus-runs 3 \
               --check-overlap \
               --enable-meta \
               --fail-on-severity medium \
@@ -237,6 +238,7 @@ jobs:
           fi
 
       - name: Upload security reports
+        id: upload
         if: steps.detect.outputs.pack_count != '0' && steps.creds.outputs.available == 'true' && always()
         uses: actions/upload-artifact@v4
         with:
@@ -257,15 +259,35 @@ jobs:
           set -euo pipefail
           MARKER="<!-- skill-security-scan -->"
           SCAN_RESULT="${{ steps.scan.outputs.scan_result }}"
+          ARTIFACT_URL="${{ steps.upload.outputs.artifact-url }}"
+          TIMESTAMP=$(date -u '+%Y-%m-%d %H:%M UTC')
 
           if [ "$SCAN_RESULT" = "passed" ]; then
             ICON="✅"
           else
             ICON="❌"
           fi
 
+          EXISTING_COMMENT_ID=$(gh api --paginate \
+            "/repos/${{ github.repository }}/issues/${PR_NUMBER}/comments" \
+            --jq ".[] | select(.body | startswith(\"$MARKER\")) | .id" \
+            | head -1)
+
+          EXISTING_BODY=""
+          RUN_NUMBER=1
+          if [ -n "$EXISTING_COMMENT_ID" ]; then
+            EXISTING_BODY=$(gh api \
+              "/repos/${{ github.repository }}/issues/comments/$EXISTING_COMMENT_ID" \
+              --jq '.body')
+            RUN_NUMBER=$(( $(echo "$EXISTING_BODY" | grep -c '### 🔄 Run #' || true) + 1 ))
+          fi
+
           {
-            echo "$MARKER"
+            if [ "$RUN_NUMBER" -eq 1 ]; then
+              echo "$MARKER"
+            fi
+            echo "### 🔄 Run #${RUN_NUMBER} — ${TIMESTAMP}"
+            echo ""
             echo "## $ICON Skill Security Scan"
             echo ""
 
@@ -286,20 +308,51 @@ jobs:
             fi
 
             echo ""
-            echo "> [Workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})"
-          } > /tmp/comment.md
-
-          EXISTING_COMMENT_ID=$(gh api --paginate \
-            "/repos/${{ github.repository }}/issues/${PR_NUMBER}/comments" \
-            --jq ".[] | select(.body | startswith(\"$MARKER\")) | .id" \
-            | head -1)
+            if [ -n "$ARTIFACT_URL" ]; then
+              echo "> 📦 [Download security reports]($ARTIFACT_URL) | [Workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})"
+            else
+              echo "> [Workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})"
+            fi
+          } > /tmp/new_report.md
 
           if [ -n "$EXISTING_COMMENT_ID" ]; then
-            gh api --method PATCH \
+            {
+              echo "$EXISTING_BODY"
+              echo ""
+              echo "---"
+              echo ""
+              cat /tmp/new_report.md
+            } > /tmp/comment.md
+            gh api \
+              --method PATCH \
               "/repos/${{ github.repository }}/issues/comments/$EXISTING_COMMENT_ID" \
               -f body="$(cat /tmp/comment.md)"
           else
             gh pr comment "$PR_NUMBER" \
               --repo "${{ github.repository }}" \
-              --body-file /tmp/comment.md
+              --body-file /tmp/new_report.md
+          fi
+
+      - name: Check scan results
+        if: steps.detect.outputs.pack_count != '0' && steps.creds.outputs.available == 'true'
+        run: |
+          if [ "${{ steps.scan.outputs.scan_result }}" = "failed" ]; then
+            echo "❌ Security scan found MEDIUM or higher severity issues — blocking merge"
+            exit 1
+          else
+            echo "✅ Security scan passed — no MEDIUM or higher severity issues found"
           fi
+
+      - name: React to PR
+        if: always()
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const result = '${{ job.status }}';
+            const prNumber = Number('${{ steps.inputs.outputs.pr_number }}');
+            await github.rest.reactions.createForIssue({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: prNumber,
+              content: result === 'success' ? '+1' : '-1'
+            });

rh-virt/mcps.json

@@ -9,8 +9,8 @@
         "--network=host",
         "--userns=keep-id:uid=65532,gid=65532",
         "-v", "${KUBECONFIG}:/kubeconfig:ro,Z",
-        "--entrypoint", "/openshift-mcp-server",
-        "quay.io/redhat-user-workloads/crt-nshift-lightspeed-tenant/openshift-mcp-server@sha256:2f52c860f91ab3c8a5129b727bdef0d620e733013f073b10355866c45eafd053",
+        "--entrypoint", "/app/kubernetes-mcp-server",
+        "quay.io/ecosystem-appeng/openshift-mcp-server@sha256:3531cb78f51f8c7ebcdb21adc21358ab8924116994848a3ce1ff542b3fc23742",
         "--kubeconfig", "/kubeconfig",
         "--toolsets", "core,kubevirt"
       ],

rh-virt/skills/vm-clone/SKILL.md

@@ -151,7 +151,11 @@ Parse: Extract storage names, calculate size, determine DataSources vs container
 
 **Option 2 warning**: `⚠️ Shared Storage Dangerous - Both VMs share disk, data corruption risk. Only safe if source stopped. Use Option 1 instead. Proceed anyway? (yes/cancel)` Wait for explicit "yes".
 
-### Step 3: Present Clone Configuration for Confirmation
+### Step 3: Check Namespace Quota and Present Clone Configuration
+
+**3.0: Check ResourceQuota** (before presenting confirmation)
+
+Use `resources_list` (apiVersion="v1", kind="ResourceQuota", namespace=`<target-namespace>`) to check if quotas exist. If a quota is found, compare current usage against limits for CPU, memory, and storage. If the clone would push usage above 80% of any limit, include a warning in the confirmation summary.
 
 **Present configuration summary:**
 
@@ -275,8 +279,8 @@ Would you like help troubleshooting this error?
 
 ### Batch Cloning
 **User request:** "Create 3 copies of template-vm named web-01, web-02, web-03"
-**Workflow**: Validate source once, generate/check target names, present combined scope, ask storage strategy, confirm, execute sequentially
-**Batch confirmation**: Show source, targets list, strategy, total impact (VMs, storage, vCPU, memory), estimated time
+**Limit**: Maximum 5 clones per batch request. If user requests more, refuse and explain the limit exists to prevent resource exhaustion.
+**Workflow**: Validate source once, generate/check target names, ask storage strategy once, then process each clone individually through Steps 3-5 with separate confirmation per VM. Stop on first failure.
 
 ### Cross-Namespace Cloning
 **User request:** "Clone production-vm from production to staging namespace"
@@ -417,17 +421,22 @@ Agent: "✓ VM Cloned Successfully"
 ```
 User: "Create 3 copies of template-vm named web-01, web-02, web-03 in production"
 
-Agent: [Validates source, checks all names, presents batch review]
-       "Source: template-vm, Targets: 3 VMs (web-01, web-02, web-03)"
-       "Total Impact: 90Gi, 6 vCPU, 12Gi, ~20-30 min"
-       "Proceed? (yes/no)"
+Agent: [Validates source, checks all names, asks storage strategy once]
+       "Storage strategy for all clones: Clone Storage (1)"
+
+       ## Clone 1 of 3: web-01
+       "Source: template-vm → Target: web-01 (production), 30Gi clone"
+       "Proceed with VM cloning? (yes/no)"
+User: "yes"
+Agent: "✓ web-01 cloned"
 
+       ## Clone 2 of 3: web-02
+       "Source: template-vm → Target: web-02 (production), 30Gi clone"
+       "Proceed with VM cloning? (yes/no)"
 User: "yes"
+Agent: "✓ web-02 cloned"
 
-Agent: "📦 Cloning VM 1 of 3: web-01... ✓"
-       "📦 Cloning VM 2 of 3: web-02... ✓"
-       "📦 Cloning VM 3 of 3: web-03... ✓"
-       "✓ Batch Cloning Completed - 3 VMs, 90Gi storage, all Stopped"
+       [... repeats for each VM with individual confirmation ...]
 ```
 
 ### Example 4: Shared Storage Warning

rh-virt/skills/vm-create/SKILL.md

@@ -83,8 +83,7 @@ Create virtual machines in OpenShift Virtualization using the `vm_create` tool f
 **Optional (use defaults):** OS (fedora), Size (medium), Storage (30Gi), Performance (u1), Autostart (false)
 
 **Gather cluster info:**
-- Detect current namespace: `kubectl config view --minify -o jsonpath='{..namespace}' || echo "default"`
-- List namespaces: `namespaces_list` (from openshift-virtualization)
+- List namespaces: `namespaces_list` (from openshift-virtualization) — ask user to select if not provided
 - List StorageClasses: `resources_list` with apiVersion="storage.k8s.io/v1", kind="StorageClass"
 - Identify default SC: annotation `storageclass.kubernetes.io/is-default-class`="true"
 - Analyze SC: `.volumeBindingMode` (Immediate/WaitForFirstConsumer), provisioner (rbd/cephfs=RWX hint)
@@ -166,15 +165,13 @@ Confirm: yes/no/modify
 **Status interpretation:**
 - Stopped/Halted → Success (VM created, not started)
 - Running → Success (if autostart=true)
-- Provisioning → Wait 5s, check again
+- Provisioning → Wait 5s, check again (max 3 retries, then report status as "still provisioning" and suggest the user check back later)
 - ErrorUnschedulable → Execute diagnostic workflow (Step 5a)
 - ErrorDataVolumeNotReady → Storage issue (see Common Issues)
 
 #### 5a. Diagnostic Workflow (ErrorUnschedulable)
 
-**CRITICAL: Document Consultation FIRST:**
-1. Read [scheduling-errors.md](../../docs/troubleshooting/scheduling-errors.md) using Read tool
-2. Output: "I detected ErrorUnschedulable. I consulted [scheduling-errors.md] to understand diagnosis strategies."
+**Reference**: See [scheduling-errors.md](../../docs/troubleshooting/scheduling-errors.md) for diagnosis strategies.
 
 **Gather diagnostics:**
 - List events: `events_list` (namespace=`<namespace>`) → Filter for VM/VMI
@@ -194,7 +191,7 @@ Confirm: yes/no/modify
 
 ### Recommended Solution
 <workaround-description>
-**Command**: `oc patch vm <name> -n <namespace> ...`
+**Action**: Update VM via `resources_create_or_update`
 **Impact**: <what-changes>
 **Options**: 1) Apply workaround, 2) Manual, 3) Cancel, 4) Ignore
 ⚠️ MCP limitation: vm_create doesn't support tolerations
@@ -203,7 +200,7 @@ Confirm: yes/no/modify
 **Wait for user decision.**
 
 **If user confirms:**
-1. Apply patch: `resources_create_or_update` (fetch, add tolerations, update) OR `oc patch`
+1. Apply patch: `resources_create_or_update` (fetch, add tolerations, update)
 2. Verify: `resources_get` → Check `.spec.template.spec.tolerations`
 3. **Restart VM**: `vm_lifecycle` (action="restart") to apply new spec
 4. Wait 15-20s, check status → Stopped → Provisioning → Running
@@ -241,7 +238,7 @@ Start: "Start VM <name>" | View: "Show VM <name>"
 **Error**: <error-message>
 
 **Common Causes**:
-- Namespace not exists → `oc create namespace <name>`
+- Namespace not exists → Create via `resources_create_or_update`
 - RBAC denied → Check ServiceAccount permissions
 - Resource constraints → Try smaller size
 - Invalid parameters → Verify OS, size, storage format
@@ -254,7 +251,7 @@ Troubleshooting: See Common Issues
 
 ### Issue 1: Namespace Not Found
 **Error**: "Namespace 'xyz' not found"
-**Solution**: List with `namespaces_list`, create with `resources_create_or_update` or `oc create namespace <name>`
+**Solution**: List with `namespaces_list`, create with `resources_create_or_update`
 
 ### Issue 2: Insufficient Permissions
 **Error**: "Forbidden: User cannot create VirtualMachines"
@@ -331,7 +328,7 @@ Troubleshooting: See Common Issues
 - **RBAC**: Requires create VirtualMachines (kubevirt.io/v1) in namespace
 - **Namespace Isolation**: VMs in specified namespace only
 - **Storage Quotas**: Respects ResourceQuotas
-- **Image Security**: Uses official images from trusted registries
+- **Image Security**: Default OS options (fedora, ubuntu, rhel, centos-stream, debian, opensuse) use upstream container disk images. Custom images via the `workload` parameter are not validated — warn the user when a custom image URL is provided and confirm the source is trusted before proceeding
 - **KUBECONFIG**: Never exposed (presence only)
 - **Audit**: All ops logged via K8s audit
 
@@ -392,6 +389,6 @@ Agent: [Creates]
 
 ## Advanced Features
 
-**Custom Images**: `vm_create({"workload": "quay.io/containerdisks/fedora:latest", ...})`
+**Custom Images**: `vm_create({"workload": "quay.io/containerdisks/fedora:latest", ...})` — ⚠️ When a custom image URL is provided, warn the user that image provenance is not verified and confirm the source is trusted before creating the VM
 **Secondary Networks**: `vm_create({"networks": ["vlan-network"], ...})` or `{"networks": [{"name": "eth1", "networkName": "vlan"}], ...}`
 **Explicit Instance Type**: `vm_create({"instancetype": "u1.large", ...})`

rh-virt/skills/vm-delete/SKILL.md

@@ -394,7 +394,7 @@ This is preview only. No resources deleted.
 ## Advanced Features
 
 ### Batch Deletion
-Delete multiple VMs with confirmation for each: `"Delete VMs test-01, test-02, test-03 in dev"` → Process each individually with full workflow. Use typed confirmation: `DELETE-3-VMS` for batch.
+Delete multiple VMs: `"Delete VMs test-01, test-02, test-03 in dev"` → Process each VM individually through the full workflow (Steps 1-5), requiring typed confirmation of each VM name separately. Never use a generic batch confirmation — each VM must be confirmed by its exact name.
 
 ### Dry-Run Mode
 Show deletion scope without executing: Execute Step 1-2, skip Steps 3-4. User request: "Show what would be deleted if I delete VM xyz"