chore(security-scan): First version of the security scan workflow#75
Merged
dmartinol merged 8 commits intoMay 5, 2026
Merged
Conversation
r2dedios
force-pushed
the
skill-security-scanner
branch
2 times, most recently
from
cb3f01b to
bca5af5
Compare
dmartinol
reviewed
May 5, 2026
dmartinol
left a comment
dmartinol
left a comment
Collaborator
There was a problem hiding this comment.
Also look at https://github.com/RHEcosystemAppEng/agentic-collections/blob/d42cc36f5f99e6fdedc20325d2e193efb201467f/.github/workflows/gemini-code-review.yml#L159 for the PR comment generation
| }); | ||
| } | ||
|
|
||
| - name: Check scan results |
Collaborator
There was a problem hiding this comment.
beware that we run the full scan of all the pack, including skills that may not be updated by the PR. For now I would just warn the user instead, so the reviewer can take decisions.
Contributor
Author
There was a problem hiding this comment.
There's a step called "Detect changed packs" to only evaluate the agentic packs that were updated in the target PR, so we are saving time and LLM usage
Collaborator
There was a problem hiding this comment.
can we change it to "detect skills" instead?
… usage Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
…on when PR comes from a Fork repo Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
are two or more modified packages Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
r2dedios
force-pushed
the
skill-security-scanner
branch
from
2654afe to
2477fdb
Compare
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pack(s) affected
rh-srerh-developerocp-adminrh-virtrh-ai-engineerChange type
mcps.json)CLAUDE.md compliance
${VAR}referencesValidation
make validatepasses locallyname,description)name,description)