Skip to content

Add PR template with CLAUDE.md compliance checklist#16

Merged
dmartinol merged 2 commits into
mainfrom
copilot/add-pr-template
Feb 25, 2026
Merged

Add PR template with CLAUDE.md compliance checklist#16
dmartinol merged 2 commits into
mainfrom
copilot/add-pr-template

Conversation

Copilot AI commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds .github/pull_request_template.md to standardize reviews and surface CLAUDE.md design principles at contribution time — keeping agents/skills separation, doc consultation discipline, and credential hygiene visible without requiring reviewers to remember them.

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-support-engineer
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (.mcp.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Create a pull request in RHEcosystemAppEng/agentic-collections (base branch: main) that adds a short PR template.

Requirements:

  • Add .github/pull_request_template.md with a concise template suitable for this repository.
  • Use the short version agreed in chat:
    • Summary
    • Pack(s) checklist
    • Change type checklist
    • CLAUDE.md compliance checklist (agents orchestrate skills; skills encapsulate tools; no direct MCP/tool calls in agents; skills single-purpose; doc consultation: read + declare)
    • Validation section
  • Ensure markdown is clean and minimal.

Deliverable:

  • Open a PR with an appropriate title and description explaining why this template was added (to encourage CLAUDE.md design compliance and consistent reviews).

This pull request was created from Copilot chat.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: dmartinol <86618610+dmartinol@users.noreply.github.com>
Copilot AI changed the title [WIP] Add pull request template for consistency and compliance Add PR template with CLAUDE.md compliance checklist Feb 25, 2026
@dmartinol dmartinol marked this pull request as ready for review February 25, 2026 22:32
@dmartinol dmartinol merged commit 7826373 into main Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants