Skip to content

docs: federation request guide, Lola URL migration, and MCP validation summary#116

Merged
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
dmartinol:bf
Jun 5, 2026
Merged

docs: federation request guide, Lola URL migration, and MCP validation summary#116
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
dmartinol:bf

Conversation

@dmartinol

Copy link
Copy Markdown
Collaborator

Summary

Improves federation contributor documentation and aligns the repo with Lola’s new home, while tightening federation validation semantics and MCP tooling output.

  • Federation docs: Adds FEDERATION_REQUEST_GUIDE.md with a mermaid process diagram (contributor → CI → maintainer), skills table, and condensed requirements/PR steps. Updates FEDERATION_REVIEW_GUIDE.md, federation skills, and marketplace comments for full-pack install scope and lola#180 (ref required here but ignored by Lola at install).
  • Remove skills: subset federation: Drops the unsupported per-skill marketplace field from docs, CI workflow, and validation scripts (validate_federation.py, fetch_federated_skills.py, validate_federation_catalog.py, collection_validate_lib.py, generate_pack_data.py).
  • Lola URL migration: Updates references from RedHatProductSecurity/lola to LobsterTrap/lola across root docs, GitHub Pages assets, pack READMEs, and catalog fragments.

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling
  • Federation (external pack)

Contribution method

  • Created/imported with /agentic-contribution-skill
  • Manual contribution (validated with make validate + make validate-skill-design-changed)

Pack-persona alignment (new skills only)

N/A — no new pack skills.

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

Test plan

  • make validate — confirm MCP summary on console and full log in .validate/mcp-tools.log
  • Review FEDERATION_REQUEST_GUIDE.md mermaid diagram renders on GitHub
  • Spot-check Lola links point to https://github.com/LobsterTrap/lola
  • Confirm marketplace federation example has no skills: field and restored comment header
  • uv run python scripts/validate_federation.py <url> --ref <sha> — Tier 2 reports as WARN, Tier 1 blocks on failure

dmartinol added 2 commits June 5, 2026 13:56
Fixed Lola repo URL
Removed "skills" field from federated modules
Added link to Lola issue 180 for the ref field

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmartinol dmartinol merged commit 7763b3a into RHEcosystemAppEng:main Jun 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant