feat: harden federation validation and catalog cross-check#112
Merged
dmartinol merged 2 commits intoJun 5, 2026
Conversation
Build on merged external-contributions infrastructure with mandatory 40-character ref SHA, federated catalog cross-check in make validate, actionable compliance errors, and removal of test federation entries. Co-authored-by: Cursor <cursoragent@cursor.com>
dmartinol
commented
Jun 5, 2026
| 2. **description** (required) | ||
| - Ask: "Describe the module in 1-2 sentences. What does it do and who is it for?" | ||
| - Validate: non-empty, under 200 characters | ||
| 2. **path** — Path to the Lola pack inside the repo (e.g., `.`, `plugins/claude-code-setup`, `my-pack`) |
Collaborator
Author
There was a problem hiding this comment.
change to skill pack
dmartinol
commented
Jun 5, 2026
| - Always append `federation` tag if not already included | ||
| | Field | Inference rules | | ||
| |-------|-------------------| | ||
| | **name** | 1) `.claude-plugin/plugin.json` → `name` · 2) basename of `path` (if not `.`) · 3) sole `skills/<dir>/` folder name · Must be kebab-case, unique in `marketplace/rh-agentic-collection.yml` | |
Collaborator
Author
There was a problem hiding this comment.
or .cursor-plugin
Use "skill pack" for path prompts and include .cursor-plugin in name inference alongside .claude-plugin. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external-contributions(PR Federation support and contribution workflow improvements #105) with federation workflow improvements: mandatory 40-characterrefcommit SHA, catalog cross-check against external repos at pinned ref, and clearer collection compliance errors (field paths and YAML line numbers).make validate(runs on every PR via compliance-check); keeps Tier 1 external skill lint inmake validate-federated.rh-automationentry pointing atr2dedios/agentic-collections; updates marketplace comments and federation skills/docs accordingly.docs/FEDERATION_REVIEW_GUIDE.md→FEDERATION_REVIEW_GUIDE.mdat repo root (links updated in README, CLAUDE.md, CONTRIBUTING.md).Test plan
make validatepasses (includes federated catalog cross-check when modules exist)make validate-collection-compliancepassesvalidate_federation.py+ catalog cross-check) — N/A until a real federated module is added in a follow-up PRrefpolicy vs optional ref in original external-contributions designMade with Cursor