Introduced AAP server in SRE plugins

[dmartinol]

• Updated the pack card title to prioritize displaying the plugin title, followed by the plugin name and pack name.
• Enhanced the search functionality to include searching by plugin title in addition to name, description, skills, and agents.
• Introduced a new JSON file for plugin titles to improve consistency and clarity in the UI.
• Added a new section in the pack details modal to display the plugin name if it differs from the title, improving user awareness of plugin identity.

[Copilot]

Pull request overview

This pull request adds plugin title support to differentiate between technical plugin identifiers and user-friendly display names, along with significant AAP (Ansible Automation Platform) integration enhancements for the SRE collection. Despite the title suggesting focus on "AAP server in SRE plugins," the changes encompass much broader functionality.

Changes:

• Introduced a docs/plugins.json file to centrally manage user-friendly plugin titles separate from technical plugin names
• Updated plugin.json files to use kebab-case identifiers (e.g., rh-sre) while displaying human-readable titles in the UI
• Enhanced the web UI to prioritize displaying plugin titles over names, with search functionality updated to include title-based searches
• Updated AAP MCP server configuration URL pattern (though with inconsistencies in variable naming)
• Added extensive AAP integration documentation including test guides, playbook integration workflows, and job execution guides
• Significantly expanded skill documentation for playbook-generator, playbook-executor, and mcp-aap-validator to detail AAP-based workflows

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
scripts/generate_pack_data.py	Added plugin title loading from docs/plugins.json and logic to override plugin names with titles
docs/plugins.json	New file mapping plugin identifiers to display titles for all collections
rh-sre/.claude-plugin/plugin.json	Changed name from "Red Hat SRE Agentic Skills Collection" to "rh-sre"
rh-support-engineer/.claude-plugin/plugin.json	Changed name from "Red Hat Support Engineer Agentic Collection" to "rh-support-engineer"
rh-virt/.claude-plugin/plugin.json	Changed name from "OpenShift Virtualization Agentic Collection" to "rh-virt"
ocp-admin/.claude-plugin/plugin.json	Changed name from "OpenShift Administration Agentic Skills Collection" to "rh-ocp-admin"
docs/app.js	Updated UI to display plugin titles, enhanced search to include titles, added plugin name display in modals when different from title
rh-sre/.mcp.json	Updated AAP MCP server URLs to use AAP_MCP_SERVER variable
rh-sre/skills/playbook-generator/SKILL.md	Added critical warnings about scope limitation (generation only, not execution) and AAP integration details
rh-sre/skills/playbook-executor/SKILL.md	Completely rewritten to describe AAP-based execution workflow with dry-run, monitoring, and comprehensive reporting
rh-sre/skills/mcp-aap-validator/SKILL.md	Enhanced to validate AAP resources (job templates, inventories) in addition to connectivity
rh-sre/agents/remediator.md	Updated to emphasize proper skill invocation patterns and AAP execution workflow
rh-sre/docs/testing/aap-integration-test-guide.md	New comprehensive test guide for AAP integration (649 lines)
rh-sre/docs/ansible/playbook-integration-aap.md	New guide for Git-based playbook integration with AAP (667 lines)
rh-sre/docs/ansible/aap-job-execution.md	New guide for AAP job execution patterns and troubleshooting (532 lines)
rh-sre/README.md	Updated playbook-executor description to mention AAP capabilities

Comments suppressed due to low confidence (1)

docs/app.js:371

• Potential null/undefined access issue in search: The search functionality accesses pack.plugin.name, pack.plugin.title, and pack.plugin.description without null-checking pack.plugin. If any pack doesn't have a plugin object, this will throw an error. Consider adding null-safe access or filtering out null values:

const searchText = [
    pack.name,
    pack.plugin?.name,
    pack.plugin?.title,
    pack.plugin?.description,
    ...pack.skills.map(s => s.name + ' ' + s.description),
    ...pack.agents.map(a => a.name + ' ' + a.description)
].filter(Boolean).join(' ').toLowerCase();

        const searchText = [
            pack.name,
            pack.plugin.name,
            pack.plugin.title,
            pack.plugin.description,
            ...pack.skills.map(s => s.name + ' ' + s.description),
            ...pack.agents.map(a => a.name + ' ' + a.description)
        ].join(' ').toLowerCase();

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 11 comments.

[r2dedios]

Good job!!