Conversation
…ichment from build process - Added notes in AGENTS.md and README.md to specify that evaluation reports are located in source repositories, not in the catalog repo. - Removed the evaluation enrichment step from build_website.py, streamlining the website build process. - Updated eval_site_enrichment.py to reflect changes in how evaluation data is handled during the build. Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git cloned from its source repo at build time;marketplace/rh-agentic-collection.ymlis the single source of truthapply_eval_enrichmentcall inbuild_website.pythat read from the catalog repo root (noeval/dir there) and silently zeroed out evaluation summaries; eval data is now read only from cloned source repos ingenerate_pack_data.py. Also added fallback topack["skills"]for packs without a catalog fileshowPackDetails()(~470 lines) and the dead pack-modal div fromapp.js/index.html; navigation now uses static collection pagesdocs/collections/<pack>.html): Skills tab infers skills from SKILL.md frontmatter for un-cataloged packs; GitLab blob URLs use/-/blob/format; link label simplified to "View SKILL.md →"deploy_and_usein catalog get a collapsible installation block on the Overview tabAGENTS.md,docs/README.md,check_site.py,deploy-pages.ymlupdated to reflect the catalog-only repo (no morecatalog/dir,catalog/**path trigger, or modal checklist items)AGENTS.mdandREADME.mdnow explicitly note thateval/<pack>/<skill>/report.jsonlives in source repos, not hereTest plan
make testpasses (validate.yml)make generatecompletes without errors and prints eval enrichment per packdocs/collections/<pack>.htmlpages render Skills tab for both cataloged and un-cataloged packs/-/blob/URLsdeploy_and_useshow the Lola install accordion on the Overview tabmake serve→ site loads, "View Details" navigates to static page, no modal references remain🤖 Generated with Claude Code