Allow subclassing an external class with deferred resolution#693
Closed
hadley wants to merge 1 commit into
Closed
Conversation
`new_class()` now accepts a `new_external_class()` as its `parent`. The child constructor takes the child's own properties plus `...`, which it forwards to the parent, so the external parent is only resolved the first time an object is constructed (not when the class is defined). This means a package can subclass a class from a soft dependency and still build and load when that dependency is absent. On first construction the class is rebuilt with the resolved parent (and the result cached), so inherited properties, validation, and dispatch all behave as if the parent had been known up front. Adds an in-process test plus a cross-package test (new fixture package t5, which subclasses ParentClass from soft dependency t1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #660 (base branch:
external-class).