feat(react,js): improve ActiveBlock TS type#683
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared SDK ActiveBlock TypeScript typing to be more precise (discriminated union by type), and simplifies React’s blockToActiveBlock construction accordingly.
Changes:
- Refactors
ActiveBlockfrom a single interface into a discriminated union with per-variantpropstypes (component,tour-component,survey). - Improves the TSDoc for
tourBlockIdand how it should be used for stable rendering keys in tours. - Removes an unnecessary
as ActiveBlock["type"]cast in the React SDK when constructingActiveBlock.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
workspaces/shared/src/types/active-block.ts |
Refactors ActiveBlock typing into a discriminated union and updates tourBlockId documentation. |
workspaces/react/src/lib/active-block.ts |
Removes a redundant type-cast when mapping a workflow block to an ActiveBlock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OPesicka
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist