other v8datamodel classes#137
Merged
luasoft10 merged 20 commits intoJun 19, 2026
Merged
Conversation
luasoft10
force-pushed
the
misc-v8datamodel-classes
branch
from
20bb687 to
0a62f51
Compare
luasoft10
force-pushed
the
misc-v8datamodel-classes
branch
from
4a78e9c to
400e562
Compare
NTx86
requested changes
Jun 19, 2026
NTx86
left a comment
NTx86
left a comment
Collaborator
There was a problem hiding this comment.
Does not build, I'm getting the following error:
\client\app\include\util\extents.h(29) : error C4716: 'RBX::Extents::operator=' : must return a value
Collaborator
Author
|
oops |
luasoft10
force-pushed
the
misc-v8datamodel-classes
branch
from
7c2632d to
59e7a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matched a lot more functions for classes in v8datamodel that were previously only declared before