Fix pre-existing master Check failures#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the pre-existing red
Checkonrace-sdk/masteras a separate stabilization cleanup, without mixing it with guest-mode development.The scope is intentionally narrow:
race-sdkRoot cause
The current
masterworkflow path was:The build steps were already green.
The failure was isolated to the Check step and only to these packages:
@race-foundation/sdk-core@race-foundation/sdk-solanaThe actual causes were deterministic and pre-existing:
sdk-corewere out of sync with current event/encryptor behaviorsdk-solanatests were still written against older account/instruction contractssdk-solanatest still imported@solana/web3.jsinstead of the current@solana/kit-based modelsdk-coreRSA test failures exposed a real implementation issue:RSA-OAEPwithSHA-256was using a512-bit modulus, which is too small for the tested encryption pathsdk-coretest suite still expected small backward-compatibleEncryptorhelpers that were no longer presentWhat changed
sdk-core
512to2048forgenerateRsaKeypair()Encryptor.create(...)encryptor.exportPublicKey()GamePlayershapesdk-solana
@solana/web3.jstest usage with@solana/kitVerification
The exact current workflow path now passes locally:
Additional targeted verification:
npm test --workspace @race-foundation/sdk-corenpm test --workspace @race-foundation/sdk-solanaNotes
This PR is intentionally separate from guest-mode work.
It does not:
racepokerrace-holdemCheck