Skip to content

Slim down dataset and clean up related scripts#152

Merged
smasongarrison merged 16 commits into
mainfrom
dev_main
Jun 2, 2026
Merged

Slim down dataset and clean up related scripts#152
smasongarrison merged 16 commits into
mainfrom
dev_main

Conversation

@smasongarrison
Copy link
Copy Markdown
Member

This pull request introduces several improvements and new features to the GEDCOM reader and its associated documentation, with a focus on better data parsing, flexibility, and code maintainability. The most important changes are summarized below.

New Features and Enhancements

  • Added a parse_dates argument to readGedcom() and postProcessGedcom() that, when enabled, parses date columns (such as birth_date and death_date) into Date objects, removing common GEDCOM date qualifiers like "ABT", "BEF", and "AFT" for improved data quality. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Improved flexibility in parent processing functions by allowing the specification of the column name for individual IDs (person_id_col) and the values representing mother/father sex (mom_sex, dad_sex). [1] [2] [3] [4] [5]

Documentation Updates

  • Updated documentation for readGedcom, postProcessGedcom, processParents, and mapFAMS2parents to reflect new arguments and clarify usage. [1] [2] [3] [4]
  • Expanded the description of the royal92 dataset to clarify its source, updates, and intended use, and updated variable names for clarity and consistency. [1] [2]

Testing and Code Quality

  • Added more unit tests for the GEDCOM reader and data parser to improve reliability.

Internal Code Improvements

  • Improved the processTag function to better handle tag normalization by removing leading underscores, enhancing robustness.

These changes collectively make the GEDCOM reader more robust, flexible, and easier to use and maintain.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@smasongarrison smasongarrison merged commit bbef98b into main Jun 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant