Slim down dataset and clean up related scripts#152
Merged
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the GEDCOM reader and its associated documentation, with a focus on better data parsing, flexibility, and code maintainability. The most important changes are summarized below.
New Features and Enhancements
parse_datesargument toreadGedcom()andpostProcessGedcom()that, when enabled, parses date columns (such asbirth_dateanddeath_date) intoDateobjects, removing common GEDCOM date qualifiers like "ABT", "BEF", and "AFT" for improved data quality. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]person_id_col) and the values representing mother/father sex (mom_sex,dad_sex). [1] [2] [3] [4] [5]Documentation Updates
readGedcom,postProcessGedcom,processParents, andmapFAMS2parentsto reflect new arguments and clarify usage. [1] [2] [3] [4]royal92dataset to clarify its source, updates, and intended use, and updated variable names for clarity and consistency. [1] [2]Testing and Code Quality
Internal Code Improvements
processTagfunction to better handle tag normalization by removing leading underscores, enhancing robustness.These changes collectively make the GEDCOM reader more robust, flexible, and easier to use and maintain.