add lib dir to dynamic linker path on macos#6
Merged
Conversation
Kazutaka333
changed the title
Kazutaka333
force-pushed
the
kaz/fix-mac-bug
branch
from
5c72fd3 to
3639b5f
Compare
Kazutaka333
force-pushed
the
kaz/fix-mac-bug
branch
from
3639b5f to
cf48944
Compare
Closed
yasuo-ozu
reviewed
Apr 10, 2026
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Install package and test deps |
Collaborator
There was a problem hiding this comment.
comment out Install package and test deps and Prepare qret stub for test (Unix) to check tool download.
Contributor
Author
There was a problem hiding this comment.
memo: debug用に残しとく
yasuo-ozu
requested changes
Apr 10, 2026
|
|
||
| elif platform.system() == "Darwin": | ||
| _append_env_path("DYLD_FALLBACK_LIBRARY_PATH", str(lib_dir)) | ||
| if not (bin_dir / "qret").exists() or not (bin_dir / "gridsynth").exists(): |
Collaborator
There was a problem hiding this comment.
this check cannot support Windows because you should specify .exe extension.
Contributor
Author
There was a problem hiding this comment.
updated the code! thanks
yasuo-ozu
requested changes
Apr 24, 2026
| # chmod +x .ci-bin/gridsynth | ||
| # echo "$GITHUB_WORKSPACE/.ci-bin" >> "$GITHUB_PATH" | ||
|
|
||
| - name: Prepare qret stub for test (Windows) |
yasuo-ozu
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closing qunasys/quri-sdk-issues#626
This PR fixes macos bug and CI instability .
Issue
qret_cli_bundle, which triggers GitHub release API/download requests.GRIDSYNTH_PATHwas only set whenbundle/bin/gridsynthexisted, but the bundled executable may be namedgridsynth.exeorgridsynth.cmd.Fix
GITHUB_TOKENinto the pytest workflow and use it when available for GitHub release API/download requests.gridsynth,gridsynth.exe, orgridsynth.cmdwhen settingGRIDSYNTH_PATH, so Windows CI resolves the bundled executable correctly.