ci: multi-transport SQL E2E (subprocess, http, unix)#2
Merged
Conversation
Parameterize ci/run-integration.sh by TRANSPORT and expand the integration job into an os x transport matrix. The same test/sql/*.test suite now runs over all three transports the vgi extension supports, by varying only the LOCATION the .test files ATTACH (VGI_COLOR_WORKER): subprocess the stdio worker binary DuckDB spawns (current behavior) http color-worker --http (auto port, advertises PORT:<n>) unix color-worker --unix <sock> (advertises UNIX:<sock>) For the http leg the script starts the worker out-of-band, discovers the port from stdout, and the awk preprocessor injects a signed INSTALL/LOAD httpfs after each LOAD vgi; (the vgi HTTP client is built on DuckDB's httpfs). A fail-on-skip guard rejects the silent auto-skip the sqllogictest runner applies to "HTTP"-containing errors, so a broken http leg can never report green-by-skip. Cleanup trap preserves the run's exit code. No worker code changes: vgi 0.6 Worker::run() already handles --http/--unix and vgi-rpc has the http feature. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rustyconover
force-pushed
the
multi-transport-sql-ci
branch
from
58ef702 to
18b290f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterizes
ci/run-integration.shbyTRANSPORTand expands the integration job into an os x transport matrix so the sametest/sql/*.testsuite runs over all three transports the vgi extension supports (subprocess, http, unix).color-worker --http, discoversPORT:<n>, injects signedINSTALL/LOAD httpfsafter eachLOAD vgi;.color-worker --unix <sock>, discoversUNIX:<sock>.Verified locally: subprocess/http/unix all GREEN (named_colors table function passes over http).
🤖 Generated with Claude Code