This repository was archived by the owner on Feb 6, 2026. It is now read-only.
html_helper#16
Draft
BenKandelaars wants to merge 5 commits into
Draft
Conversation
alanclarke
reviewed
Sep 9, 2021
| This repo contains these sets | ||
|
|
||
| - @qubit/utils/dom | ||
| - @qubit/html |
Contributor
There was a problem hiding this comment.
should this be @qubit/utils/html?
alanclarke
reviewed
Sep 9, 2021
| const closestElement = closest(targetElement, selectors) | ||
| ``` | ||
|
|
||
| ### @qubit/html |
Contributor
There was a problem hiding this comment.
@qubit/html would be a different package right?
Contributor
Author
There was a problem hiding this comment.
I was wondering if it should be part of utils because it is directly related to html element creation
Contributor
There was a problem hiding this comment.
Right but the name @qubit/html implies a separate package, did you mean @qubit/utils/html?
Contributor
|
Just wondering what kind of stuff do we want to live here vs stuff that should live in the |
Contributor
|
also, do we want to encourage people to create elements this way vs using jsx? |
BenKandelaars
force-pushed
the
html_helper
branch
6 times, most recently
from
September 21, 2021 17:10
6e1d88c to
1f08a37
Compare
BenKandelaars
force-pushed
the
html_helper
branch
from
September 21, 2021 17:35
81973d7 to
a858416
Compare
Contributor
Author
|
I've found this useful when doing badging placements that are so small preact feels like overkill |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a few small badge type placements. Found it clearer to use a configuration based API to create elements