Remove invalidations workflow#57
Merged
Krastanov merged 1 commit intoFeb 20, 2026
Merged
Conversation
The invalidations workflow can be overly strict and block legitimate PRs that happen to increase invalidation counts, even when the changes are correct and necessary. While invalidation tracking can be useful for performance-critical code, it's better suited as an optional local check rather than a required CI step that blocks all PRs. Reasons for removal: - Blocks valid PRs that unavoidably increase invalidations - Not all invalidations are problematic - Can be run locally if needed: `using SnoopCompileCore; invalidations = @Snoopr using MyPackage` - Other performance metrics (benchmarks, profiling) are more actionable 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 7 7
Lines 757 757
=======================================
Hits 720 720
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
invalidations.ymlworkflow that blocks PRs based on method invalidation counts.Rationale
The invalidations workflow can be overly strict and blocks legitimate PRs, even when the changes are correct and necessary.
Problems with invalidations workflow:
Better alternatives:
✅ Benchmark workflows - We already have these for performance tracking
✅ Local profiling - Developers can check invalidations locally if concerned:
✅ Code review - Performance concerns can be discussed in PR reviews
What this doesn't affect:
Changes
.github/workflows/invalidations.ymlTest Plan
🤖 Generated with Claude Code