Skip to content

Remove invalidations workflow#57

Merged
Krastanov merged 1 commit into
QuantumSavory:mainfrom
Krastanov-agent:remove-invalidations-workflow
Feb 20, 2026
Merged

Remove invalidations workflow#57
Krastanov merged 1 commit into
QuantumSavory:mainfrom
Krastanov-agent:remove-invalidations-workflow

Conversation

@Krastanov-agent

Copy link
Copy Markdown
Contributor

Summary

Removes the invalidations.yml workflow that blocks PRs based on method invalidation counts.

Rationale

The invalidations workflow can be overly strict and blocks legitimate PRs, even when the changes are correct and necessary.

Problems with invalidations workflow:

  1. Blocks valid PRs - Many legitimate changes increase invalidations
  2. Not all invalidations are bad - Context matters more than raw counts
  3. False positives - Dependencies can cause invalidations beyond our control
  4. Poor developer experience - Arbitrary blocking of otherwise good PRs

Better alternatives:

Benchmark workflows - We already have these for performance tracking
Local profiling - Developers can check invalidations locally if concerned:

using SnoopCompileCore
invalidations = @snoopr using MyPackage

Code review - Performance concerns can be discussed in PR reviews

What this doesn't affect:

  • ✅ Benchmark workflows still track performance
  • ✅ CI tests still verify correctness
  • ✅ Code review still catches issues
  • ✅ Developers can still check invalidations locally

Changes

  • Deletes .github/workflows/invalidations.yml

Test Plan

  • Verify invalidations.yml is removed
  • Confirm CI still runs other essential checks (tests, benchmarks)
  • PRs no longer blocked by invalidation count increases

🤖 Generated with Claude Code

The invalidations workflow can be overly strict and block legitimate PRs
that happen to increase invalidation counts, even when the changes are
correct and necessary.

While invalidation tracking can be useful for performance-critical code,
it's better suited as an optional local check rather than a required CI
step that blocks all PRs.

Reasons for removal:
- Blocks valid PRs that unavoidably increase invalidations
- Not all invalidations are problematic
- Can be run locally if needed: `using SnoopCompileCore; invalidations = @Snoopr using MyPackage`
- Other performance metrics (benchmarks, profiling) are more actionable

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@Krastanov Krastanov merged commit b11805f into QuantumSavory:main Feb 20, 2026
7 of 11 checks passed
@codecov

codecov Bot commented Feb 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (a696995) to head (df78607).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files           7        7           
  Lines         757      757           
=======================================
  Hits          720      720           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants