Conversation
…HSS 0.5 / OrdinaryDiffEqTsit5 2
Drop the `ModelingToolkit` weakdep in favour of `ModelingToolkitBase`. The extension and its tests are renamed `ModelingToolkitBaseExt` and the trigger, imports, and `function ModelingToolkit.System / ODEProblem / NonlinearProblem / SteadyStateProblem` method definitions are rebased onto `ModelingToolkitBase` instead. Test now imports `ModelingToolkitBase` and uses `System` rather than the removed `ODESystem`. `ode_order_lowering` previously relied on `Symbolics.var_from_nested_derivative`, which only counts the outer wrapper when `D(D(x))` is collapsed into one `Differential(t, 2)(x)` (as it is under Symbolics 7). A local `_var_and_order` walks chained `Differential`s and sums their `order` fields. Compat: Symbolics 7, SymbolicUtils 4, ModelingToolkitBase 1, OrdinaryDiffEqTsit5 2, HarmonicSteadyState 0.5; bump to v0.17.0. Aqua's `stale_deps` is told to ignore `ModelingToolkitBase` since it is reachable only through the extension. The DifferentialEquation overload of `ODEProblem` (via `@mtkcompile`) is broken under MTK 11 because the lowered derivative variable becomes a parameter; that test is marked `@test_broken` for a separate follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
HarmonicBalance.jl! Please make sure you have finished the following tasks before finishing the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Describe the proposed change here.
Related issues or PRs
Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]
Additional context