Fix pre-existing typecheck failures in register tests (CLI-FND-002)

[cryptoxdog]

Stacked PR — quality fix on top of #38

Stacked on #38 (Phase 3). Base is claude/new-session-br7qjb-phase-3; this PR's diff shows only the register-test fix. Retarget to main once the stack lands.

Problem

npm run typecheck (the assurance typecheck gate uses tsconfig.check.json, which includes tests/) fails with 3 pre-existing TS2493 errors — present at base 0a660de, unrelated to any prior PR in this stack:

tests/api/register-enriched.e2e.test.ts(100,47): error TS2493
tests/api/register-enriched.e2e.test.ts(115,47): error TS2493
tests/api/register.test.ts(59,47): error TS2493

Each is a valuesMock.mock.calls[0][0] read (the first insert().values(...) argument). valuesMock was defined as vi.fn(() => ({ … })) — a zero-argument implementation — so vitest infers its call-args as the empty tuple [], and indexing [0] on a length-0 tuple is a compile error.

Fix

Declare the argument the mock actually receives:

const valuesMock = vi.fn((_values: Record<string, unknown>) => ({ onConflictDoUpdate: onConflictDoUpdateMock }));

Now mock.calls[0] is a non-empty tuple and [0] typechecks. No runtime or behavior change — the impl still returns the same chain object; the register suites pass unchanged (13 tests).

Evidence

• npm run typecheck → exit 0, 0 errors (was 3).
• NODE_ENV=test vitest run → 149/149.

This is the fix for finding CLI-FND-002 recorded in the unthrottle pack.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud