chore(lint): add ESLint 9 flat config so npm run lint works - #35
Open
cryptoxdog wants to merge 1 commit into
Open
chore(lint): add ESLint 9 flat config so npm run lint works#35cryptoxdog wants to merge 1 commit into
cryptoxdog wants to merge 1 commit into
Conversation
The lint script pointed at ESLint 9 with no config file present, so it exited nonzero on every invocation — the script existed but had never been runnable. Adds eslint.config.js (flat, ESM, TypeScript) plus the two devDeps ESLint 9 requires for TS: @eslint/js and typescript-eslint. Not type-aware: tsconfig excludes tests/, so recommendedTypeChecked would fail on the parser rather than on a real rule. no-explicit-any and no-unused-vars land as warn, not error. This codebase has never been linted; the 58 any and 15 unused-binding findings are pre-existing debt made visible rather than a wall of failures on first run. Raise both to error once cleared. Also picks up the generated formatter-ownership block in AGENTS.md. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
lintscript pointed at ESLint 9 with no config file present, so it exited nonzero on every invocation — the script existed but had never been runnable.eslint.config.js— flat, ESM, TypeScript. Not type-aware:tsconfigexcludestests/, sorecommendedTypeCheckedwould fail on the parser rather than on a real rule.@eslint/jsandtypescript-eslintdevDeps — the two packages ESLint 9 requires for TS.no-explicit-anyandno-unused-varsland as warn, not error. This codebase has never been linted; the 58anyand 15 unused-binding findings are pre-existing debt made visible rather than a wall of failures on first run. Raise both to error once cleared.AGENTS.md.Written and unverified. The config is valid ESM and the devDeps are declared, but it was never executed:
npm installfails with a 401 againstnpm.pkg.github.comfor the private@quantum-l9/llm-routerdependency, sonode_modulesis empty locally and this repo has nopackage-lock.jsonto install from.You'll want to run
npm install && npm run lintthere once authenticated to the private registry before merging.Test plan
npm installnpm run lint— expect 0 errors, warnings onlyMade with Cursor