Recipes calling relax/static jobs now return a dict#3158
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3158 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 98 98
Lines 4282 4295 +13
=======================================
+ Hits 4181 4194 +13
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@claude review this PR |
|
What is the status of this one again? |
|
@Andrew-S-Rosen - all we need here is to require Let me make that change so that when they do make a release, this PR can be merged. |
…cc into vb/subflow_fix2
|
@Andrew-S-Rosen - this PR is ready for merge. Tests will fail right now, but as soon as the next release of jobflow is made (>0.3.1), we can re-run the CI and merge if passing. |
|
I opened an issue on |
This PR uses some changes in
jobflowReplacebehavior to test if the idea ofsubflows returning a dict{"relax": <list-of-jobs>, "static": <list-of-jobs>}might work. The upstream changes are from a fork ofjobflowand a custom branch, till we're satisfied with the behavior, at which point we can open a PR onjobflow.