Remove retired AIAudit readiness coupling - #214
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc1e673c8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -647,24 +489,6 @@ def evaluate_readiness( | |||
| checks.append(f"Loaded auto-merge policy label `{label}`.") | |||
| checks.append(f"Loaded high-risk human-review label `{human_review_label}`.") | |||
|
|
|||
There was a problem hiding this comment.
When CODEX_AUDIT_AUTO_MERGE is enabled, .github/workflows/auto_merge_codex_pr.yml still invokes this readiness check immediately before gh pr merge, and the monthly and feedback workflows still use its outcome to permit auto-merge dispatches. Removing all three workflow validations therefore makes readiness return success even if an active workflow loses its same-repository, head-SHA, review, retry, or readiness gates. Keep these checks until those workflows are actually retired, or retire their triggers and merge path in the same change.
Useful? React with 👍 / 👎.
| f"{repo} --body false\n" | ||
| "```\n\n" | ||
| "High-risk PRs remain blocked by the source merge guard even after enablement.\n" | ||
| "3. Automatic merge remains disabled. This report does not instruct a workflow enablement, variable change, or merge action.\n" |
There was a problem hiding this comment.
This statement is false whenever the repository already has CODEX_AUDIT_AUTO_MERGE=true: the active auto-merge workflow is explicitly gated on that variable, while the planner is still generated and posted by monthly_review.yml. Because this change also removes repository-variable discovery, an enabled deployment now receives a report asserting that automatic merge is disabled even though qualifying PRs can still be merged automatically; retain the discovery or phrase this solely as a recommendation rather than current state.
Useful? React with 👍 / 👎.
|
Closing unmerged under |
1 participant
Summary
auto_merge=falseskip behaviorValidation
PYTHONPATH=src python3 -m pytest -q(702 passed, 4 skipped)Bounded Phase B cleanup; no workflow, repository-settings, or P2 business changes.