Retire active AIAudit workflow paths - #213
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89c8dd9615
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permissions: | ||
| actions: write | ||
| contents: read | ||
| issues: write |
There was a problem hiding this comment.
Whenever source_run_id is populated—including every automatic workflow_run invocation—the workflow executes gh run download, but this explicit permissions block now omits actions, so that scope is set to none. GitHub documents that unspecified scopes become none when a permissions block is present and that downloading an artifact requires Actions (read) permission; consequently the download fails before any report is built. Replace the removed write permission with actions: read.
Useful? React with 👍 / 👎.
| `monthly-review` issue. It does not dispatch an AI reviewer, retry review | ||
| feedback, create remediation pull requests, or prepare or perform auto-merge. |
There was a problem hiding this comment.
When this workflow is eventually enabled, scripts/run_monthly_report_bundle.py still puts “Low-risk ... fixes may be automated” into the posted issue body at line 1055 and asks which tasks qualify for “unattended remediation” at line 1422. Since the retained workflow posts that generated file directly, every monthly issue will contradict this new boundary and direct reviewers toward automation that this commit has retired. Update the active report renderer and its assertions so the generated evidence also describes manual follow-up only.
Useful? React with 👍 / 👎.
| def test_retired_aiaudit_workflows_are_removed() -> None: | ||
| assert not Path(".github/workflows/codex_pr_feedback.yml").exists() | ||
| assert not Path(".github/workflows/auto_merge_codex_pr.yml").exists() |
There was a problem hiding this comment.
The CI workflow runs the complete python -m pytest -q suite, but tests/test_check_codex_auto_merge_readiness.py still calls evaluate_readiness() with default paths pointing to the now-deleted feedback workflow and the now-report-only monthly workflow. Running that dependency-light test module after this change produces 16 failures because every readiness result gains missing-workflow and missing-Bridge-dispatch errors, including cases that assert readiness succeeds or expect one specific error. Update or retire those tests and the corresponding readiness assumptions as part of this deletion so the required CI job can pass.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
python3 -m pytest tests/test_monthly_review_workflow_config.py -quvx --offline ruff check tests/test_monthly_review_workflow_config.pypython3 -m compileall -q tests/test_monthly_review_workflow_config.pyactionlint .github/workflows/monthly_review.ymlScope
The retained monthly workflow remains disabled pending a separate report-only activation decision.