Skip to content

[codex] Use central Codex PR review workflow #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 3 commits into from
Jul 5, 2026
Merged

[codex] Use central Codex PR review workflow #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22c5b59
ci: reuse central codex pr review
Pigbibi Jul 4, 2026
f2e7a3b
ci: allow advisory codex review when backend is absent
Pigbibi Jul 5, 2026
df67cb1
ci: keep codex review runner compatibility stub
Pigbibi Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 10 additions & 35 deletions .github/workflows/codex_pr_review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
name: Codex PR Review

# Always run on PRs to guarantee a check run exists for branch protection.
# The Python script handles skip logic internally for trivial changes.
on:
pull_request:
types: [opened, synchronize, reopened]
Expand All @@ -18,36 +16,13 @@ concurrency:

jobs:
review:
runs-on: ubuntu-latest
timeout-minutes: 30
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"

steps:
- name: Checkout
uses: actions/checkout@v6

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: "3.11"

- name: Run Codex PR Review
id: review
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
ANTHROPIC_MODEL: ${{ vars.ANTHROPIC_MODEL || 'claude-sonnet-4-6' }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
OPENAI_MODEL: ${{ vars.OPENAI_MODEL || 'gpt-5.4-mini' }}
CODEX_AUDIT_SERVICE_URL: ${{ secrets.CODEX_AUDIT_SERVICE_URL }}
CODEX_AUDIT_SERVICE_AUDIENCE: ${{ vars.CODEX_AUDIT_SERVICE_AUDIENCE || 'quant-codex-audit' }}
run: python scripts/run_codex_pr_review.py

- name: Upload review diagnostics
if: always()
uses: actions/upload-artifact@v7
with:
name: codex-pr-review-${{ github.event.pull_request.number }}-${{ github.run_id }}
path: data/output/codex_pr_review/
if-no-files-found: warn
uses: QuantStrategyLab/AIAuditBridge/.github/workflows/codex_pr_review.yml@main
with:
caller_concurrency_key: pr-${{ github.event.pull_request.number || github.run_id }}
allow_unconfigured_backend: true
secrets: inherit
Comment on lines +19 to +23

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass only the review secrets to the called workflow

In caller repos that have secrets beyond the Codex review backend, secrets: inherit makes every repo/org secret available to the reusable workflow in QuantStrategyLab/AIAuditBridge@main, including secrets that workflow does not declare. Because this job also points at a mutable external main ref, any future incompatible or compromised bridge workflow can read those additional credentials during PR review; the old local job only exposed the review-specific keys in its environment. Please pass the specific secrets this workflow needs instead of inheriting all of them.

Useful? React with 👍 / 👎.

permissions:
contents: read
id-token: write
issues: write
pull-requests: write
Loading
Loading