Skip to content

fix(ui): exclude non-runtime strategies from switch dropdown #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 7, 2026
Merged

fix(ui): exclude non-runtime strategies from switch dropdown #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/strategy-switch-console/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,13 +1584,13 @@
const cleanProfile = cleanStrategyProfile(profile);
const catalogEntry = strategyCatalogEntry(cleanProfile);
if (!catalogEntry.profile) return false;
if (catalogEntry.runtime_enabled !== true) return false;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow paper-only strategy switches

This rejects every non-runtime profile before checking the selected execution mode, but the worker still treats paper-only candidates as valid: assertStrategyAllowedForAccount only requires runtime_enabled for execution_mode === "live", and the validation test explicitly allows us_equity_combo_leveraged in paper mode. For paper accounts, these allowed_execution_modes: ["paper", ...] shadow/candidate strategies disappear from the UI, so users can no longer launch paper experiments that the backend still supports.

Useful? React with 👍 / 👎.

if (dcaConfigForStrategy(cleanProfile) && !platformSupportsDca(platform)) return false;
if (!supportedDomainsForAccount(platform, account).includes(catalogEntry.domain)) return false;
const mode = normalizeExecutionMode(executionMode, false);
if (mode === "live") return strategyCanSwitchLive(catalogEntry);
const allowedModes = normalizeAllowedExecutionModes(catalogEntry.allowed_execution_modes);
if (allowedModes.length && !allowedModes.includes(mode)) return false;
if (catalogEntry.runtime_enabled !== true && !allowedModes.length) return false;
return true;
}

Expand Down
2 changes: 1 addition & 1 deletion web/strategy-switch-console/app_js.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading