feat(Phase2): index.html config now injected from platform-config.json - #133
Closed
Pigbibi wants to merge 1 commit into
Closed
feat(Phase2): index.html config now injected from platform-config.json#133Pigbibi wants to merge 1 commit into
Pigbibi wants to merge 1 commit into
Conversation
- build_platform_config.py now injects <script id="platform-config">
into index.html with generated config globals
- index.html inline script uses window.__PLATFORM_CONFIG__ || {fallback}
pattern — generated values take priority, hardcoded is fallback
- 4 key blocks migrated: platformConfig, defaultAccountOptions,
incomeLayer/optionOverlay defaults, dcaProfileDefaults
- All 11 hardcoded blocks still exist as fallback for safety
config flow: platform-config.json → build → injected <script> + config.js
Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of config unification:
Platform capabilities now modified in ONE place: platform-config.json