feat: unified config — platform-config.json single source of truth - #132
Merged
Conversation
Architecture change (Phase 1): - build_platform_config.py generates config.js from platform-config.json - worker.js now imports DCA_SUPPORTED_PLATFORMS, PLATFORM_*_VARIABLES from config.js instead of hardcoding - Fix platform-config.json: Schwab dca=true, LongBridge dca=true, add default_strategy_profile for all platforms - Deploy workflow: run build_platform_config.py instead of build_config.py Eliminates duplicate config between worker.js and page_asset.js. Next phase: migrate index.html hardcoded defaults to import config.js. Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1: Config unification
build_platform_config.pygenerates bothconfig.jsandstrategy_profiles_asset.jsfromplatform-config.jsonworker.jsnow imports DCA platform list from config instead of hardcodingDCA_SUPPORTED_PLATFORMS,PLATFORM_MIN_RESERVED_CASH_VARIABLES,PLATFORM_RESERVED_CASH_RATIO_VARIABLESfrom worker.jsplatform-config.json: Schwab dca=true, LongBridge dca=truebuild_platform_config.pyArchitecture
🤖 Generated with Claude Code