Skip to content

chore: pin review capacity classification bridge #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 11, 2026
Merged

chore: pin review capacity classification bridge #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable-drift-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ jobs:
uses: actions/checkout@v6
with:
repository: QuantStrategyLab/AIAuditBridge
ref: 66b1107f7cb081ab1409e8b6ebdc6334999fa5dc
ref: 59192b259bfbc4c959e7799ae514e2e5d4925498

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin only bridge builds that trust this workflow SHA

This bridge revision still deploys the Codex audit service with CODEX_AUDIT_SERVICE_ALLOWED_JOB_WORKFLOW_REFS ending at QuantPlatformKit/.github/workflows/reusable-drift-check.yml@fcddef20eea5deb876e739263042acdcb3e9cd1b; it does not include the new reusable-workflow commit 32d4cc676f068c1bf2431383c1f4fc4419b8d622. When strategy repos update their pinned uses: ref to this commit, GitHub's OIDC job_workflow_ref identifies the called workflow at that SHA, so the audit service rejects the dual-review submission before the new capacity classification can run, causing critical-drift dual reviews to fail closed instead of degrading/dispatching. Please use a bridge revision/deployment that already allowlists this QPK SHA or keep callers on an allowlisted QPK pin.

Useful? React with 👍 / 👎.

path: external/AIAuditBridge

- name: Dual-review critical drift
Expand Down
2 changes: 1 addition & 1 deletion tests/test_reusable_drift_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
assert "create_issues_for_domain" in workflow
assert 'CODEX_AUDIT_SERVICE_URL: ${{ secrets.codex_audit_service_url }}' in workflow
assert 'AI_GATEWAY_SERVICE_URL: ${{ inputs.ai_gateway_service_url }}' in workflow
assert 'ref: 66b1107f7cb081ab1409e8b6ebdc6334999fa5dc' in workflow
assert 'ref: 59192b259bfbc4c959e7799ae514e2e5d4925498' in workflow
assert workflow.count('GH_TOKEN: ${{ github.token }}') >= 2
assert 'if [ "$review_rc" -eq 3 ]; then' in workflow
assert 'item.get("dispatch", {}).get("github_issue")' in workflow
Expand Down
Loading