Skip to content

fix: preserve caller lifecycle context in reusable drift checks #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 3 commits into from
Jul 10, 2026
Merged

fix: preserve caller lifecycle context in reusable drift checks #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae0c9d7
fix: parameterize reusable drift lifecycle context
Pigbibi Jul 10, 2026
a590fb0
fix: pin reusable drift checkout to workflow revision
Pigbibi Jul 10, 2026
07874f2
fix: route reusable drift issues to caller
Pigbibi Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/reusable-drift-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ on:
required: false
type: string
default: ""
lifecycle_performance_bucket:
required: false
type: string
default: ""
caller_event_name:
required: true
type: string
Expand All @@ -46,7 +50,7 @@ jobs:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
STRATEGY_DOMAIN: ${{ inputs.strategy_domain }}
QUANT_PROJECTS_ROOT: ${{ github.workspace }}/external
LIFECYCLE_PERFORMANCE_BUCKET: ${{ vars.LIFECYCLE_PERFORMANCE_BUCKET || '' }}
LIFECYCLE_PERFORMANCE_BUCKET: ${{ inputs.lifecycle_performance_bucket || vars.LIFECYCLE_PERFORMANCE_BUCKET || '' }}
LIFECYCLE_LOCAL_ROOT: ${{ github.workspace }}/data/lifecycle_store

steps:
Expand Down Expand Up @@ -157,7 +161,15 @@ jobs:
GITHUB_REPOSITORY: ${{ github.repository }}
run: |
python - <<'PY'
import os

from quant_platform_kit.strategy_lifecycle.codex_integration import create_issues_for_domain

owner, _, repository = os.environ["GITHUB_REPOSITORY"].partition("/")
if not owner or not repository:
raise RuntimeError("GITHUB_REPOSITORY must identify the reusable workflow caller")
os.environ["CODEX_AUDIT_ORG"] = owner
os.environ["CODEX_AUDIT_ORCHESTRATOR_REPO"] = repository
results = create_issues_for_domain("${{ inputs.strategy_domain }}")
created = [item for item in results if item.get("issue_url")]
print({"created_issues": len(created), "results": len(results)})
Expand Down
5 changes: 4 additions & 1 deletion tests/test_reusable_drift_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
assert "snapshot_repository_token:" in workflow
assert "snapshot_checkout_path:" in workflow
assert "ai_gateway_service_url:" in workflow
assert "lifecycle_performance_bucket:" in workflow
assert "caller_event_name:" in workflow
assert "caller_pr_head_repository:" in workflow
assert "codex_audit_service_url:" in workflow
assert 'python-version: ${{ inputs.python_version }}' in workflow
assert 'LIFECYCLE_PERFORMANCE_BUCKET: ${{ vars.LIFECYCLE_PERFORMANCE_BUCKET || \'\' }}' in workflow
assert "LIFECYCLE_PERFORMANCE_BUCKET: ${{ inputs.lifecycle_performance_bucket || vars.LIFECYCLE_PERFORMANCE_BUCKET || '' }}" in workflow
assert "Validate trusted caller" in workflow
assert "Untrusted reusable workflow caller" in workflow
assert "caller_event_name must be provided by the caller workflow" in workflow
Expand All @@ -39,6 +40,8 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
assert 'token: ${{ secrets.snapshot_repository_token || github.token }}' in workflow
assert 'ref: ${{ github.workflow_sha }}' in workflow
assert 'GH_TOKEN: ${{ github.token }}' in workflow
assert 'os.environ["CODEX_AUDIT_ORG"] = owner' in workflow
assert 'os.environ["CODEX_AUDIT_ORCHESTRATOR_REPO"] = repository' in workflow
assert "create_issues_for_domain" in workflow
assert 'CODEX_AUDIT_SERVICE_URL: ${{ secrets.codex_audit_service_url }}' in workflow
assert 'AI_GATEWAY_SERVICE_URL: ${{ inputs.ai_gateway_service_url }}' in workflow
Expand Down
Loading