Skip to content

chore(deps): align QPK pin to f07f0bdeb658 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pigbibi wants to merge 1 commit into from
Closed

chore(deps): align QPK pin to f07f0bdeb658 #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies = [
"google-cloud-storage",
"google-auth",
"longport==3.0.23",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f07f0bdeb6580e1f28109830ccde85cb8ace092a",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep qsl metadata pin in sync

Changing the install pin here without updating qsl.toml leaves the repository metadata advertising the old QPK commit (2381aa...) while pyproject.toml installs f07f0.... This is already enforced by tests/test_qsl_metadata.py, which compares qsl.requires.quant_platform_kit with this dependency pin, so CI fails immediately and any metadata-driven bundle checks will see the wrong platform revision.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the dependency to QPK_PIN, not the QPK commit

The Check QPK pin consistency workflow reads external/QuantPlatformKit/QPK_PIN; that file is the compatibility SHA, not necessarily the QuantPlatformKit repo commit SHA (for example, at f07f0..., QPK_PIN contains f0d6bc...). Pinning this dependency to f07f0... therefore makes the blocking guard reject pyproject.toml/uv.lock even after the local metadata mismatch is fixed.

Useful? React with 👍 / 👎.

"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@17ddb86c72d44b2c7b78ba7a10d8f71b21180166",
"hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@b6a8ac2ad3c8110b5ea74fb059c8206388d63bcd",
]
Expand Down Expand Up @@ -61,5 +61,5 @@ include = [

[tool.uv]
override-dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f07f0bdeb6580e1f28109830ccde85cb8ace092a",
]
6 changes: 3 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading