feat(risk): stamp consecutive_losses before strategy evaluate - #315
Conversation
Reuse QPK stamp helper so entrypoint circuit breakers see trailing loss streak from live equity history. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59b6d1c1a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name = "quant-platform-kit" | ||
| version = "0.10.0" | ||
| source = { git = "https://github.com/QuantStrategyLab/QuantPlatformKit.git?rev=53b2ca73a5a50257b5d1a3c769b75c40924e4ba6#53b2ca73a5a50257b5d1a3c769b75c40924e4ba6" } | ||
| source = { git = "https://github.com/QuantStrategyLab/QuantPlatformKit.git?rev=69a0256934d081b5ef309a885384b9eb9f62cf90#53b2ca73a5a50257b5d1a3c769b75c40924e4ba6" } |
There was a problem hiding this comment.
When building through the frozen lockfile path used by the runtime image (Dockerfile:18), uv sync --frozen --no-dev --dry-run still selects quant-platform-kit @ ...53b2ca73... because this locked source keeps the old fragment after # even though the requested rev was changed to 69a02569.... The new runtime code imports stamp_consecutive_losses_on_snapshot from QPK, so deployed images can run the old QPK revision and fail as soon as a portfolio snapshot is evaluated; regenerate or fix the lock entry so the resolved commit matches the new pin.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
Summary
consecutive_lossesontoportfolio_snapshotbefore strategy evaluate via QPKstamp_consecutive_losses_on_snapshot69a0256(QPK #211)Test plan
Made with Cursor