Support public HK snapshot artifact source - #127
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7b73f77e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| python -m pip install -e '.[longbridge]' | ||
| case "${DATA_SOURCE_MODE}" in | ||
| public_yfinance_staging) | ||
| python -m pip install -e '.[public-data]' |
There was a problem hiding this comment.
Install yfinance for the public data mode
When the workflow runs with the new default data_source_mode=public_yfinance_staging, this installs hk-equity-snapshot-pipelines[public-data], but the current HkEquitySnapshotPipelines pyproject.toml only defines test and longbridge extras, while the public snapshot provider raises if yfinance is unavailable. Pip will only warn about the unknown extra and install the base package, so the default public run reaches scripts/build_low_vol_dividend_public_factor_snapshot.py and fails before producing artifacts.
Useful? React with 👍 / 👎.
Summary
data_source_modeto the HK low-vol snapshot bridge workflowpublic_yfinance_staging, while preserving LongBridge OpenAPI modeVerification
.venv/bin/python -m ruff check ..venv/bin/python -m pytest -qruby -e "require 'yaml'; YAML.load_file('.github/workflows/build-hk-low-vol-snapshot-artifacts.yml'); puts 'yaml ok'"