Skip to content

Support public HK snapshot artifact source - #127

Merged
Pigbibi merged 1 commit into
mainfrom
codex/public-yfinance-hk-snapshot
Jun 3, 2026
Merged

Support public HK snapshot artifact source#127
Pigbibi merged 1 commit into
mainfrom
codex/public-yfinance-hk-snapshot

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add data_source_mode to the HK low-vol snapshot bridge workflow
  • default the bridge to public_yfinance_staging, while preserving LongBridge OpenAPI mode
  • only retrieve LongBridge secrets for LongBridge-generated inputs
  • update HK runtime docs for broker-independent snapshot artifact generation

Verification

  • .venv/bin/python -m ruff check .
  • .venv/bin/python -m pytest -q
  • ruby -e "require 'yaml'; YAML.load_file('.github/workflows/build-hk-low-vol-snapshot-artifacts.yml'); puts 'yaml ok'"

@Pigbibi
Pigbibi merged commit 9cd3c6f into main Jun 3, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/public-yfinance-hk-snapshot branch June 3, 2026 07:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7b73f77e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

python -m pip install -e '.[longbridge]'
case "${DATA_SOURCE_MODE}" in
public_yfinance_staging)
python -m pip install -e '.[public-data]'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Install yfinance for the public data mode

When the workflow runs with the new default data_source_mode=public_yfinance_staging, this installs hk-equity-snapshot-pipelines[public-data], but the current HkEquitySnapshotPipelines pyproject.toml only defines test and longbridge extras, while the public snapshot provider raises if yfinance is unavailable. Pip will only warn about the unknown extra and install the base package, so the default public run reaches scripts/build_low_vol_dividend_public_factor_snapshot.py and fails before producing artifacts.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant