Add per-service IBKR env sync plan - #90
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcb9bbf71b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SHARED_TARGET_FALLBACK_ENV = frozenset( | ||
| { | ||
| "GLOBAL_TELEGRAM_CHAT_ID", | ||
| "NOTIFY_LANG", | ||
| "IB_ACCOUNT_GROUP_CONFIG_SECRET_NAME", | ||
| "IB_GATEWAY_ZONE", | ||
| "IB_GATEWAY_IP_MODE", | ||
| "EXECUTION_REPORT_GCS_URI", |
There was a problem hiding this comment.
Preserve global safety env fallbacks in per-service mode
When CLOUD_RUN_SERVICE_TARGETS_JSON is used, only names in SHARED_TARGET_FALLBACK_ENV can fall back to repository-level env vars; IBKR_PAPER_LIQUIDATE_ONLY and cash guard vars are omitted from that allowlist even though they are still modeled as target env keys. As a result, existing repo-level settings are interpreted as absent and get pushed into remove_env_vars, so the sync step removes them from every Cloud Run service during migration to per-service mode. This can silently disable liquidation-only / cash-protection runtime safeguards unless operators duplicate those values into every target/default entry.
Useful? React with 👍 / 👎.
Summary
Tests