Support IBKR slot env sync targets - #89
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 333fe3296f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| mapfile -t target_services < <(resolve_cloud_run_services) | ||
| if [ "${#target_services[@]}" -eq 0 ]; then | ||
| required_vars+=("CLOUD_RUN_SERVICES or CLOUD_RUN_SERVICE") |
There was a problem hiding this comment.
Handle missing service vars without invalid indirection
Do not append the literal string "CLOUD_RUN_SERVICES or CLOUD_RUN_SERVICE" to required_vars here, because the later loop dereferences each entry via ${!var_name:-}. When neither service variable is set, this value is not a valid shell identifier, so bash exits with invalid variable name before producing the intended missing-variable report. This breaks validation behavior in the exact misconfiguration path this check is meant to handle.
Useful? React with 👍 / 👎.
Summary
Tests