Skip to content

Support IBKR slot env sync targets - #89

Merged
Pigbibi merged 1 commit into
mainfrom
fix/ibkr-env-sync-slots
May 25, 2026
Merged

Support IBKR slot env sync targets#89
Pigbibi merged 1 commit into
mainfrom
fix/ibkr-env-sync-slots

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add CLOUD_RUN_SERVICES support for syncing one or more Cloud Run services
  • keep CLOUD_RUN_SERVICE as the single-service fallback
  • add optional CLOUD_RUN_ENV_SYNC_WAIT_FOR_COMMIT=false for nonstandard deployment flows
  • document why slot deployments must not enable shared env sync until runtime identity is modeled per slot

Tests

  • bash tests/test_sync_cloud_run_env_workflow.sh
  • .venv/bin/python -m ruff check .

@Pigbibi
Pigbibi merged commit 5b76c4b into main May 25, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/ibkr-env-sync-slots branch May 25, 2026 16:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 333fe3296f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


mapfile -t target_services < <(resolve_cloud_run_services)
if [ "${#target_services[@]}" -eq 0 ]; then
required_vars+=("CLOUD_RUN_SERVICES or CLOUD_RUN_SERVICE")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle missing service vars without invalid indirection

Do not append the literal string "CLOUD_RUN_SERVICES or CLOUD_RUN_SERVICE" to required_vars here, because the later loop dereferences each entry via ${!var_name:-}. When neither service variable is set, this value is not a valid shell identifier, so bash exits with invalid variable name before producing the intended missing-variable report. This breaks validation behavior in the exact misconfiguration path this check is meant to handle.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant