Skip to content

Remove legacy crisis alert email config - #77

Merged
Pigbibi merged 1 commit into
mainfrom
remove-googlevoice-legacy-aliases
May 24, 2026
Merged

Remove legacy crisis alert email config#77
Pigbibi merged 1 commit into
mainfrom
remove-googlevoice-legacy-aliases

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove CRISIS_ALERT_EMAIL_TO and CRISIS_ALERT_EMAIL_FROM from runtime config and Cloud Run env sync
  • document Google Voice notification config as the only crisis alert recipient surface
  • update QuantPlatformKit and UsEquityStrategies pins to the Google Voice-only cleanup commits

Tests

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src:/home/ubuntu/Projects/UsEquityStrategies/src:. .venv/bin/python -m pytest tests/test_runtime_config_support.py tests/test_request_handling.py
  • bash tests/test_sync_cloud_run_env_workflow.sh

@Pigbibi
Pigbibi merged commit 4fb2423 into main May 24, 2026
1 check passed
@Pigbibi
Pigbibi deleted the remove-googlevoice-legacy-aliases branch May 24, 2026 18:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 206c9e4633

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -372,24 +370,12 @@ jobs:
remove_env_vars+=("CRISIS_ALERT_GOOGLE_VOICE_TO")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove legacy alert vars during Cloud Run sync

This change drops CRISIS_ALERT_EMAIL_TO/CRISIS_ALERT_EMAIL_FROM from both env_pairs and remove_env_vars, so the gcloud run services update call no longer removes those keys from existing services. In environments that already have these legacy variables set, they will persist indefinitely and the "legacy config removed" migration is incomplete, leaving stale runtime configuration drift after each sync.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant