Remove legacy crisis alert email config - #77
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 206c9e4633
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -372,24 +370,12 @@ jobs: | |||
| remove_env_vars+=("CRISIS_ALERT_GOOGLE_VOICE_TO") | |||
There was a problem hiding this comment.
Remove legacy alert vars during Cloud Run sync
This change drops CRISIS_ALERT_EMAIL_TO/CRISIS_ALERT_EMAIL_FROM from both env_pairs and remove_env_vars, so the gcloud run services update call no longer removes those keys from existing services. In environments that already have these legacy variables set, they will persist indefinitely and the "legacy config removed" migration is incomplete, leaving stale runtime configuration drift after each sync.
Useful? React with 👍 / 👎.
Summary
Tests