-
Notifications
You must be signed in to change notification settings - Fork 1
Adopt IBKR runtime target JSON wiring #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
10c34f4
Pin dynamic RSI strategy dependencies
Pigbibi 417c0f5
Adopt runtime target assembly
Pigbibi c8c368d
Fix runtime target env sync wiring
Pigbibi 6d6b57d
Fix runtime target import wiring
Pigbibi 6817040
Fix Cloud Run env sync JSON encoding
Pigbibi 222e6a2
Require IBKR runtime target JSON
Pigbibi 317b22b
Merge remote-tracking branch 'origin/main' into codex/soxl-dynamic-rs…
Pigbibi ab56e51
Pin UsEquityStrategies runtime target dependency
Pigbibi 7487415
Merge remote-tracking branch 'origin/main' into codex/soxl-dynamic-rs…
Pigbibi 109d4f2
Update IBKR tests for runtime target JSON
Pigbibi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow now forwards
RUNTIME_TARGET_JSONto Cloud Run, but this step only validatesstrategy_profileand never checks required fields likeplatform_idanddry_run_only(orexecution_modeconsistency). The runtime loader now enforces those fields viaresolve_runtime_target_from_env, so an incomplete JSON (for example, one containing onlystrategy_profile) will pass CI here and then fail service startup after env sync, causing a broken revision in production.Useful? React with 👍 / 👎.