Skip to content

chore(deps): align QPK pin to f0d6bc739943 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pigbibi wants to merge 1 commit into from
Closed

chore(deps): align QPK pin to f0d6bc739943 #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies = [
"google-cloud-secret-manager",
"google-cloud-storage",
"yfinance",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f0d6bc7399433b9a1ccdaab1f0874faf184cfa84",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin QPK to the canonical QPK_PIN SHA

This updates the dependency to the QPK repository commit f0d6bc..., but that checkout's QPK_PIN points to de18c2e9d93bcfc2220148a99749447059a6f4c6. I checked the CI path in .github/workflows/ci.yml:113-118: it runs external/QuantPlatformKit/scripts/check_qpk_pin_consistency.py --pin-file external/QuantPlatformKit/QPK_PIN, so this line, the override, and uv.lock will be reported as mismatches and the PR will stay red until they use the QPK_PIN SHA instead of the sync commit SHA.

Useful? React with 👍 / 👎.

"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@17ddb86c72d44b2c7b78ba7a10d8f71b21180166",
"hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@b6a8ac2ad3c8110b5ea74fb059c8206388d63bcd",
]
Expand Down Expand Up @@ -64,5 +64,5 @@ include = [

[tool.uv]
override-dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f0d6bc7399433b9a1ccdaab1f0874faf184cfa84",
]
6 changes: 3 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading