Skip to content

fix(execution): bridge cash-only sell-funded buys - #325

Merged
Pigbibi merged 2 commits into
mainfrom
agent/fix-cash-only-sell-funded-buy
Jul 10, 2026
Merged

fix(execution): bridge cash-only sell-funded buys#325
Pigbibi merged 2 commits into
mainfrom
agent/fix-cash-only-sell-funded-buy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • bridge projected sell proceeds into live cash-only buy budget when cash snapshots are stale
  • allow a 1-share top-up for existing underweight holdings that miss by less than one whole share
  • add a regression test covering the SOXL sell / SOXX buy live cash-only path

Testing

  • python3 -m pytest -q tests/test_execution_service.py tests/test_runtime_broker_adapters.py

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8c339a759

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread application/execution_service.py Outdated
Comment thread application/execution_service.py Outdated
Comment thread application/execution_service.py Outdated
Comment thread application/execution_service.py Outdated
Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi
Pigbibi enabled auto-merge (squash) July 10, 2026 09:24
@Pigbibi
Pigbibi disabled auto-merge July 10, 2026 09:26
@Pigbibi
Pigbibi enabled auto-merge (squash) July 10, 2026 09:26
@Pigbibi
Pigbibi merged commit da26f1b into main Jul 10, 2026
2 checks passed
@Pigbibi
Pigbibi deleted the agent/fix-cash-only-sell-funded-buy branch July 10, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant