fix(notify): clarify submitted order is unconfirmed - #323
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Submitteddoes not confirm broker acceptance or fill and may still be rejected or cancelledQPK_PINso CI can validate this branchRoot Cause
The runtime treated
Submitted/PendingSubmitas a successful submission for notification purposes and rendered copy that implied the order had been safely handed off. During the read-only gateway incident that message was misleading because the broker could still reject the order afterward.Separately, the repository QPK pin had drifted behind the current upstream
QPK_PIN, which blocks CI before tests run.Validation
python3 scripts/check_qpk_pin_consistency.py --root . --pin-file /tmp/QPK_PIN_INTERACTIVEpython3 -m pytest tests/test_execution_service.py -q