Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ google-cloud-compute
google-cloud-secret-manager
google-cloud-storage
yfinance
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@b9a7df85cfc848cebcc3aa6e1d77ec34ca7611ab
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the constraints pin with the requirement

When the Docker image is built, Dockerfile copies both files and runs python -m pip install -r requirements.txt -c constraints.txt, but constraints.txt:6 still pins quant-platform-kit to b9a7df... while this line now requests 0063af.... I checked pip install --help, which describes -c, --constraint as constraining versions, and pip rejects conflicting direct-URL requirements for the same package, so this commit makes container builds fail until the constraint is updated too.

Useful? React with 👍 / 👎.

us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@64342a1e95a687c29a2be6f0b771e4a7be15b8b8
hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@3746fa4b10806feb50a51d1aa449ccf8aee7b1ae
Loading