[codex] prune legacy backup execution schedulers - #288
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 573894ebcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| account_suffix="${cloud_run_service#interactive-brokers-quant-live-}" | ||
| account_suffix="${account_suffix%-service}" | ||
| if [[ "${account_suffix}" == u* ]]; then | ||
| legacy_candidates+=("ibkr-${account_suffix}-backup-execution") |
There was a problem hiding this comment.
When the sync plan contains the current per-account live service names already used in this repo, such as interactive-brokers-live-u1599-tqqq-service in tests/test_cloud_run_runtime_guard.py, this substitution does not strip the prefix, leaving account_suffix as interactive-brokers-live-u1599-tqqq; the u* guard is then false and the intended ibkr-u1599-tqqq-backup-execution candidate is never deleted. In those live-u* environments the legacy /run scheduler remains and can continue the duplicate close-time execution this change is meant to remove, so the derivation needs to cover the interactive-brokers-live- naming scheme as well.
Useful? React with 👍 / 👎.
1 participant
Summary
Root cause
Legacy backup execution jobs still call /run at 15:52 ET while primary service schedulers run at 15:45 ET, causing duplicate close-time executions.
Validation