Skip to content

Complete strategy notification translations #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Apr 17, 2026
Merged

Complete strategy notification translations #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions notifications/telegram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"strategy_name_russell_1000_multi_factor_defensive": "罗素1000多因子",
"strategy_name_tech_communication_pullback_enhancement": "科技通信回调增强",
"strategy_name_qqq_tech_enhancement": "科技通信回调增强",
"strategy_name_mega_cap_leader_rotation_aggressive": "Mega Cap 激进龙头轮动",
"strategy_name_mega_cap_leader_rotation_dynamic_top20": "Mega Cap 动态 Top20 龙头轮动",
"strategy_name_dynamic_mega_leveraged_pullback": "Mega Cap 2x 回调策略",
"strategy_name_tqqq_growth_income": "TQQQ 增长收益",
Expand Down Expand Up @@ -143,6 +144,7 @@
"strategy_name_russell_1000_multi_factor_defensive": "Russell 1000 Multi-Factor",
"strategy_name_tech_communication_pullback_enhancement": "Tech/Communication Pullback Enhancement",
"strategy_name_qqq_tech_enhancement": "Tech/Communication Pullback Enhancement",
"strategy_name_mega_cap_leader_rotation_aggressive": "Mega Cap Leader Rotation Aggressive",
"strategy_name_mega_cap_leader_rotation_dynamic_top20": "Mega Cap Leader Rotation Dynamic Top20",
"strategy_name_dynamic_mega_leveraged_pullback": "Dynamic Mega Leveraged Pullback",
"strategy_name_tqqq_growth_income": "TQQQ Growth Income",
Expand Down
12 changes: 12 additions & 0 deletions tests/test_notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from notifications.telegram import build_strategy_display_name, build_translator, send_telegram_message
from strategy_registry import SUPPORTED_STRATEGY_PROFILES


def test_build_translator_supports_chinese():
Expand All @@ -24,12 +25,23 @@ def test_strategy_display_name_translates_new_live_profiles():
zh_name = build_strategy_display_name(build_translator("zh"))
en_name = build_strategy_display_name(build_translator("en"))

assert zh_name("mega_cap_leader_rotation_aggressive") == "Mega Cap 激进龙头轮动"
assert zh_name("mega_cap_leader_rotation_dynamic_top20") == "Mega Cap 动态 Top20 龙头轮动"
assert zh_name("dynamic_mega_leveraged_pullback") == "Mega Cap 2x 回调策略"
assert en_name("mega_cap_leader_rotation_aggressive") == "Mega Cap Leader Rotation Aggressive"
assert en_name("mega_cap_leader_rotation_dynamic_top20") == "Mega Cap Leader Rotation Dynamic Top20"
assert en_name("dynamic_mega_leveraged_pullback") == "Dynamic Mega Leveraged Pullback"


def test_supported_strategy_profiles_have_translated_names():
zh_name = build_strategy_display_name(build_translator("zh"))
en_name = build_strategy_display_name(build_translator("en"))

for profile in SUPPORTED_STRATEGY_PROFILES:
assert zh_name(profile) != profile
assert en_name(profile) != profile


def test_send_telegram_message_logs_non_200_response(capsys):
class FakeResponse:
status_code = 401
Expand Down