Support income layer runtime controls - #176
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b3e16496
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "INCOME_LAYER_ENABLED", | ||
| "INCOME_LAYER_MAX_RATIO", | ||
| "RUNTIME_TARGET_ENABLED", |
There was a problem hiding this comment.
Export new runtime-control vars to the sync plan
When this script is run by .github/workflows/sync-cloud-run-env.yml, only variables explicitly exported in the job env are visible before python scripts/build_cloud_run_env_sync_plan.py --json runs; the workflow exports the existing IBKR controls but not these newly-added names. In legacy/shared configurations, setting RUNTIME_TARGET_ENABLED=false or the income-layer vars as GitHub Actions variables is therefore treated as absent and the generated plan removes them, so a target that should be paused can be re-enabled unless the value is embedded in CLOUD_RUN_SERVICE_TARGETS_JSON.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d2e5e40e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if dry_run_only_override is None and not getattr(RUNTIME_SETTINGS, "runtime_target_enabled", True): | ||
| return "Runtime Target Disabled", 200 |
There was a problem hiding this comment.
Let configured dry-run targets keep running
When a service is configured with IBKR_DRY_RUN_ONLY=true, /run is still a dry run because the composer/broker adapters use RUNTIME_SETTINGS.dry_run_only whenever dry_run_only_override is None. This new guard blocks those POSTs solely because they came through /run, so setting RUNTIME_TARGET_ENABLED=false on a dry-run-only target (for example the scheduler path used by verify/paper targets) stops the dry run even though the control is meant to pause official runs while dry runs and probes continue.
Useful? React with 👍 / 👎.
Summary
Tests