Skip to content

Drop legacy runtime routes - #175

Merged
Pigbibi merged 1 commit into
mainfrom
codex/drop-legacy-runtime-routes-20260618
Jun 18, 2026
Merged

Drop legacy runtime routes#175
Pigbibi merged 1 commit into
mainfrom
codex/drop-legacy-runtime-routes-20260618

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove legacy root and /precheck strategy entrypoints in favor of /run and /dry-run
  • point Cloud Scheduler dry-run jobs at /dry-run while keeping existing scheduler job names
  • rename dry-run runtime logs away from precheck wording

Tests

  • ../.venv/bin/python -m pytest tests/test_request_handling.py
  • bash tests/test_sync_cloud_run_env_workflow.sh

@Pigbibi
Pigbibi merged commit 2891ae6 into main Jun 18, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/drop-legacy-runtime-routes-20260618 branch June 18, 2026 13:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c569cf23a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

case "${suffix}" in
scheduler)
schedule_time="${main_time}"
scheduler_path="/run"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update heartbeat matching before switching jobs to /run

When the scheduler sync rewrites the main job to ${service_url}/run, the scheduler-aware heartbeat no longer recognizes that job: scripts/execution_report_heartbeat.py only treats scheduler URIs with path / as strategy-run jobs and then includes a service when no matching job is found. For less-frequent targets such as monthly services, this makes every configured service look due on every heartbeat run, causing false missing-report alerts/failures even on days the main scheduler did not run. Update the heartbeat matcher to accept the new /run path as part of this route migration.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant