Skip to content

[codex] Clarify runtime route roles - #174

Merged
Pigbibi merged 1 commit into
mainfrom
codex/runtime-route-roles-20260618
Jun 18, 2026
Merged

[codex] Clarify runtime route roles#174
Pigbibi merged 1 commit into
mainfrom
codex/runtime-route-roles-20260618

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add explicit /run and /dry-run aliases for runtime route roles
  • keep existing / and /precheck compatibility routes
  • keep health probes success-silent and stop loading strategy plugins during broker/account probes
  • update route tests

Validation

  • /home/ubuntu/Projects/platform-runtime-work/.venv/bin/python -m pytest tests/test_request_handling.py

@Pigbibi
Pigbibi merged commit 27b5a55 into main Jun 18, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/runtime-route-roles-20260618 branch June 18, 2026 13:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee33663541

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread main.py


@app.route("/", methods=["POST", "GET"])
@app.route("/run", methods=["POST", "GET"])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update heartbeat before exposing /run alias

When a Cloud Scheduler main job is switched to this new /run alias, the execution-report heartbeat still only recognizes scheduler targets whose parsed path is exactly / (scripts/execution_report_heartbeat.py lines 286-289), and _filter_scheduler_due_services treats unmatched services as due (lines 413-420). For monthly or otherwise off-cycle services, that makes the heartbeat require a fresh report even on days when the /run job was not scheduled, causing false production alerts; please teach the heartbeat to accept /run before exposing it as an equivalent runtime route.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant