[codex] Clarify runtime route roles - #174
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee33663541
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| @app.route("/", methods=["POST", "GET"]) | ||
| @app.route("/run", methods=["POST", "GET"]) |
There was a problem hiding this comment.
Update heartbeat before exposing /run alias
When a Cloud Scheduler main job is switched to this new /run alias, the execution-report heartbeat still only recognizes scheduler targets whose parsed path is exactly / (scripts/execution_report_heartbeat.py lines 286-289), and _filter_scheduler_due_services treats unmatched services as due (lines 413-420). For monthly or otherwise off-cycle services, that makes the heartbeat require a fresh report even on days when the /run job was not scheduled, causing false production alerts; please teach the heartbeat to accept /run before exposing it as an equivalent runtime route.
Useful? React with 👍 / 👎.
Summary
Validation