Show TQQQ delever allocation in notifications - #170
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 114722996c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allocation_detail = _format_tqqq_volatility_delever_allocation_detail( | ||
| signal_metadata, | ||
| prefix=prefix, | ||
| redirect_symbol=redirect_symbol or "QQQ", | ||
| translator=translator, |
There was a problem hiding this comment.
Include allocation detail in sent compact notifications
In the live IBKR Telegram path with TQQQ delever applied, this new allocation_detail only reaches the detailed dashboard built here; run_strategy_core still passes render_trade_notification a strategy_dashboard from application.rebalance_service._strategy_dashboard_text (application/rebalance_service.py:357), which only includes dashboard/timing, and NotificationPublisher sends compact_text (tests/test_notification_events.py:12). As a result, the retained/redirected allocation is logged but omitted from the actual sent Telegram compact message, so the feature does not show up for users unless the compact path uses the enriched renderer dashboard too.
Useful? React with 👍 / 👎.
Summary
Validation