Materialize IBKR HK market history inputs - #131
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dff31fa6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def _get_direct_market_history_profiles() -> frozenset[str]: | ||
| try: | ||
| from hk_equity_strategies import get_direct_market_history_profiles |
There was a problem hiding this comment.
Use a helper available in the pinned HK package
With the current requirements.txt pin for hk-equity-strategies (71141ce9...), this top-level get_direct_market_history_profiles symbol is not exported, so the import falls into the compatibility fallback and _requires_materialized_market_history() is false for hk_listed_global_etf_rotation. In that deployed environment the materialization path never runs and the HK strategy still receives the loader callable as market_history, which its direct market-history implementation treats as row/mapping input, causing HK dry runs to fail before producing targets; please either update the dependency pin or keep a local fallback allow-list for the enabled HK direct profile.
Useful? React with 👍 / 👎.
Summary
Verification
Full pytest was not run on the VPS because the available Python environments do not have pytest/pandas installed, and installing pandas on this 2GB VPS is intentionally avoided.