Skip to content

[codex] Use async Artifact Registry image cleanup #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
May 31, 2026
Merged

[codex] Use async Artifact Registry image cleanup #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/sync-cloud-run-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,5 +804,6 @@ jobs:
gcloud artifacts docker images delete "${image_repo}@${digest}" \
--project="${GCP_PROJECT_ID}" \
--delete-tags \
--async \

@chatgpt-codex-connector chatgpt-codex-connector Bot May 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wait for asynchronous image deletes to finish

In this cleanup loop, adding --async means the workflow exits after each delete operation is submitted rather than after Artifact Registry reports that it completed; the gcloud reference for this flag says it returns immediately without waiting for the operation. When Artifact Registry later rejects a delete (for example a digest that fails a precondition or another backend-side delete error), this step still finishes green, so old Cloud Run images remain in the repository and cleanup regressions are hidden from CI. Please either wait on the returned operations or keep the synchronous delete so failures still fail the workflow.

Useful? React with 👍 / 👎.

--quiet
done <<< "${old_digests}"