Infer quote overlay state in notifications - #117
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43f9d8b601
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if normalized_source in { | ||
| "longbridge_candlesticks", | ||
| "historical_close", | ||
| "snapshot_close", | ||
| "market_quote", | ||
| }: | ||
| return False |
There was a problem hiding this comment.
Mark mixed fallback sources as no overlay
When any symbols use fallback pricing, application/execution_service.py records price_source_mode as mixed_market_quote_<fallback> and main.py copies that into signal_snapshot.latest_price_source; those values are already localized as mixed_market_quote_snapshot_close / mixed_market_quote_historical_close. Because this allowlist only matches the exact fallback source names, those normal fallback runs still render quote overlay unknown even though they are market-quote/fallback modes with no live quote overlay. Please include the mixed market-quote fallback modes in the false inference.
Useful? React with 👍 / 👎.
Summary
Verification