Skip to content

Infer quote overlay state in notifications - #117

Merged
Pigbibi merged 1 commit into
mainfrom
codex/infer-quote-overlay-state-20260529
May 29, 2026
Merged

Infer quote overlay state in notifications#117
Pigbibi merged 1 commit into
mainfrom
codex/infer-quote-overlay-state-20260529

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • infer quote-overlay state from known signal snapshot source names
  • keep explicit quote_overlay_used values authoritative

Verification

  • PYTHONPATH=.:../QuantPlatformKit/src ../QuantPlatformKit/.venv/bin/python -m py_compile notifications/renderers.py
  • PYTHONPATH=.:../QuantPlatformKit/src ../QuantPlatformKit/.venv/bin/ruff check notifications/renderers.py
  • git diff --check

@Pigbibi
Pigbibi merged commit 5488aa6 into main May 29, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/infer-quote-overlay-state-20260529 branch May 29, 2026 03:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43f9d8b601

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +114 to +120
if normalized_source in {
"longbridge_candlesticks",
"historical_close",
"snapshot_close",
"market_quote",
}:
return False

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark mixed fallback sources as no overlay

When any symbols use fallback pricing, application/execution_service.py records price_source_mode as mixed_market_quote_<fallback> and main.py copies that into signal_snapshot.latest_price_source; those values are already localized as mixed_market_quote_snapshot_close / mixed_market_quote_historical_close. Because this allowlist only matches the exact fallback source names, those normal fallback runs still render quote overlay unknown even though they are market-quote/fallback modes with no live quote overlay. Please include the mixed market-quote fallback modes in the false inference.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant